Issue 9652026: Download the DRT archive instead of the full dartium

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9652026: Download the DRT archive instead of the full dartium (Closed)

Created:
8 years, 9 months ago by vsm

Modified:
8 years, 9 months ago

Reviewers:
Siggi Cherem (dart-lang), Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Download the DRT archive instead of the full dartium Committed: https://code.google.com/p/dart/source/detail?r=5361

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixed error message #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -13 lines)			Patch
	M	tools/get_drt.py	View	1	2 chunks	+6 lines, -13 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

8 years, 9 months ago (2012-03-12 16:12:13 UTC) #2

lgtm

http://codereview.chromium.org/9652026/diff/1/tools/get_drt.py
File tools/get_drt.py (right):

http://codereview.chromium.org/9652026/diff/1/tools/get_drt.py#newcode119
tools/get_drt.py:119: print "Tests using arch=chromium will not work. Please try
again later."
this message is a bit old, can we change to say just in words that some browser
tests might not work?

Expand Messages | Collapse Messages