Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 9649015: Change string used to annotate static type issues to 'static type warning' in multitest (Closed)

Created:
8 years, 9 months ago by zundel
Modified:
8 years, 9 months ago
CC:
reviews_dartlang.org, gbracha, ahe
Visibility:
Public.

Description

Change string used to annotate static type issues to 'static type warning' in multitest Gilad requested we update the annotation used in multitests to reflect the terminology used in the Dart specification. Committed: https://code.google.com/p/dart/source/detail?r=5233

Patch Set 1 #

Patch Set 2 : Merged up to tip #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -56 lines) Patch
M tests/language/src/AssignStaticTypeTest.dart View 1 1 chunk +6 lines, -6 lines 0 comments Download
M tests/language/src/CyclicTypeVariableTest.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M tests/language/src/DefaultFactory2Test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/src/FBoundedQuantificationTest.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/src/FauxverrideTest.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M tests/language/src/FieldOverrideTest.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/src/GettersSetters2Test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/language/src/ImplicitThisTest.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M tests/language/src/NamedParametersTypeTest.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/src/OverrideFieldTest.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/src/OverrideMethodWithFieldTest.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/src/Setter3Test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/src/StringInterpolationTest.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/src/TypeVariableBounds2Test.dart View 2 chunks +6 lines, -6 lines 0 comments Download
M tests/language/src/TypeVariableBoundsTest.dart View 3 chunks +8 lines, -8 lines 0 comments Download
M tests/language/src/WrongNumberTypeArgumentsTest.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/testing/dart/multitest.dart View 1 5 chunks +7 lines, -7 lines 0 comments Download
M tools/testing/dart/test_runner.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/testing/dart/test_suite.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
zundel
The static analysis engine is the only implementation that actually does anything with these annotations ...
8 years, 9 months ago (2012-03-09 01:18:45 UTC) #1
Mads Ager (google)
lgtm
8 years, 9 months ago (2012-03-09 13:16:05 UTC) #2
Bill Hesse
8 years, 9 months ago (2012-03-09 13:57:16 UTC) #3
LGTM.

Powered by Google App Engine
This is Rietveld 408576698