Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 9649011: Take out force browser close. (Closed)

Created:
8 years, 9 months ago by Emily Fortuna
Modified:
8 years, 9 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Take out force browser close. Now that the tests are more stable with the batch runner, we won't force all browser windows to close. If it seems this is still needed on the buildbots, we'll move the logic into builbot_annotated_steps.py. Committed: https://code.google.com/p/dart/source/detail?r=5263

Patch Set 1 : #

Total comments: 3

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -49 lines) Patch
M tools/testing/dart/test_runner.dart View 1 4 chunks +8 lines, -49 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Emily Fortuna
Hi Bill, I'm sorry it's taken me so long to integrate your comments from this ...
8 years, 9 months ago (2012-03-09 00:29:12 UTC) #1
Bill Hesse
8 years, 9 months ago (2012-03-09 09:37:02 UTC) #2
LGTM, with comments.

https://chromiumcodereview.appspot.com/9649011/diff/2001/tools/testing/dart/t...
File tools/testing/dart/test_runner.dart (right):

https://chromiumcodereview.appspot.com/9649011/diff/2001/tools/testing/dart/t...
tools/testing/dart/test_runner.dart:465: bool allowRetries = false;
false is always overwritten by null or the provided value in the constructor.

https://chromiumcodereview.appspot.com/9649011/diff/2001/tools/testing/dart/t...
tools/testing/dart/test_runner.dart:471: [this.allowRetries,
this.processQueue]);
this.allowRetries = false

https://chromiumcodereview.appspot.com/9649011/diff/2001/tools/testing/dart/t...
tools/testing/dart/test_runner.dart:487: if (allowRetries &&
testCase.usesWebDriver
According to the spec, the optional [this.allowRetries] parameter in the
constructor is effectively the same as [this.allowRetries = null], and it
overwrites the false default value.  I just checked in the vm and in dartboard,
and the value will be null.

Powered by Google App Engine
This is Rietveld 408576698