Issue 9646008: Implementing ConstructorCall. (part I)

Issue 9646008: Implementing ConstructorCall. (part I) (Closed)

Created:
8 years, 9 months ago by srdjan

Modified:
8 years, 9 months ago

Reviewers:
Kevin Millikin (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Implementing ConstructorCall: part I. Committed: https://code.google.com/p/dart/source/detail?r=5264

Patch Set 7 : #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+151 lines, -15 lines)			Patch
M	runtime/vm/flow_graph_builder.h	View	1 2 3 4 5	2 chunks	+4 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	1 2 3 4 5 6	4 chunks	+87 lines, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	1 2 3 4 5 6	2 chunks	+15 lines, -3 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1 2 3 4 5 6	5 chunks	+45 lines, -10 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

srdjan

https://chromiumcodereview.appspot.com/9646008/diff/12/runtime/vm/intermediate_language.h File runtime/vm/intermediate_language.h (right): https://chromiumcodereview.appspot.com/9646008/diff/12/runtime/vm/intermediate_language.h#newcode133 runtime/vm/intermediate_language.h:133: ASSERT(value.IsZoneHandle()); This is needed in order to pass types ...

8 years, 9 months ago (2012-03-09 02:37:47 UTC) #2

Kevin Millikin (Google)

LGTM as a work in progress. I think it looks like the right approach, based ...

8 years, 9 months ago (2012-03-09 12:40:39 UTC) #3

srdjan

8 years, 9 months ago (2012-03-09 22:40:48 UTC) #4

https://chromiumcodereview.appspot.com/9646008/diff/12/runtime/vm/intermediat...
File runtime/vm/intermediate_language.h (right):

https://chromiumcodereview.appspot.com/9646008/diff/12/runtime/vm/intermediat...
runtime/vm/intermediate_language.h:528: explicit
AllocateObjectComp(ConstructorCallNode* node) : ast_node_(*node) {}
On 2012/03/09 02:37:47, srdjan wrote:
> Will add two Values: type arguments and instantiator. Will probably change the
> allocation stub to always accept those two arguments (currently the allocation
> stub for types without type arguments do not expect the two values)

Changed opinion: adding an array of values (lebgth 0 or 2). Using same same
allocation stub as before.

Expand Messages | Collapse Messages