Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(863)

Issue 9642003: Start using Dart_SetField and Dart_GetField in the vm. (Closed)

Created:
8 years, 9 months ago by turnidge
Modified:
8 years, 9 months ago
Reviewers:
cshapiro
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Start using Dart_SetField and Dart_GetField in the vm. Committed: https://code.google.com/p/dart/source/detail?r=5185

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -78 lines) Patch
M runtime/bin/dartutils.h View 1 1 chunk +8 lines, -8 lines 0 comments Download
M runtime/bin/dartutils.cc View 1 1 chunk +14 lines, -15 lines 0 comments Download
M runtime/bin/directory.cc View 1 2 chunks +6 lines, -6 lines 0 comments Download
M runtime/bin/eventhandler.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/main.cc View 1 2 chunks +2 lines, -4 lines 0 comments Download
M runtime/bin/process.cc View 1 4 chunks +13 lines, -13 lines 0 comments Download
M runtime/bin/socket.cc View 1 8 chunks +14 lines, -14 lines 0 comments Download
M runtime/vm/custom_isolate_test.cc View 1 2 3 chunks +3 lines, -15 lines 0 comments Download
M runtime/vm/snapshot_test.cc View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
turnidge
Hi Carl, A little renaming and refactoring here. Care to take a look? Todd
8 years, 9 months ago (2012-03-08 18:30:44 UTC) #1
cshapiro
8 years, 9 months ago (2012-03-08 18:36:17 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698