Issue 9639012: Implement the compiler API and use it in frog_leg.dart.

Issue 9639012: Implement the compiler API and use it in frog_leg.dart. (Closed)

Created:
8 years, 9 months ago by ahe

Modified:
8 years, 9 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org, compiler-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Implement the compiler API and use it in frog_leg.dart. Committed: https://code.google.com/p/dart/source/detail?r=5177

Patch Set 1 #

Total comments: 10

Patch Set 2 : Addressed review comments and created separate implementation library #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+101 lines, -145 lines)			Patch
M	dart/frog/leg/api.dart	View	1	2 chunks	+14 lines, -4 lines	0 comments	Download
A	dart/frog/leg/apiimpl.dart	View	1	1 chunk	+58 lines, -0 lines	0 comments	Download
M	dart/frog/leg/compiler.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	dart/frog/leg/frog_leg.dart	View	1	1 chunk	+27 lines, -139 lines	0 comments	Download
M	dart/tests/language/language-leg.status	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. Looking forward to seeing the error message handling improve again. https://chromiumcodereview.appspot.com/9639012/diff/1/dart/frog/leg/api.dart File dart/frog/leg/api.dart (right): ...

8 years, 9 months ago (2012-03-08 15:13:01 UTC) #2

ahe

8 years, 9 months ago (2012-03-08 16:29:41 UTC) #3

Hi Kasper,

Thank you for your comments.

Cheers,
Peter

https://chromiumcodereview.appspot.com/9639012/diff/1/dart/frog/leg/api.dart
File dart/frog/leg/api.dart (right):

https://chromiumcodereview.appspot.com/9639012/diff/1/dart/frog/leg/api.dart#...
dart/frog/leg/api.dart:8: #import('ssa/tracer.dart');
On 2012/03/08 15:13:02, kasperl wrote:
> Should we give this a prefix too?

Done.

https://chromiumcodereview.appspot.com/9639012/diff/1/dart/frog/leg/api.dart#...
dart/frog/leg/api.dart:41: ReadUriFromString provider, DiagnosticHandler
handler) {
On 2012/03/08 15:13:02, kasperl wrote:
> In these cases I prefer one argument per line.

I don't agree, but done.

https://chromiumcodereview.appspot.com/9639012/diff/1/dart/frog/leg/api.dart#...
dart/frog/leg/api.dart:81: text = provider(uri).value;
On 2012/03/08 15:13:02, kasperl wrote:
> Maybe add a comment here that explain why this is not a good long term
strategy
> (to help others debug any temporary issues).

Done.

https://chromiumcodereview.appspot.com/9639012/diff/1/dart/frog/leg/frog_leg....
File dart/frog/leg/frog_leg.dart (right):

https://chromiumcodereview.appspot.com/9639012/diff/1/dart/frog/leg/frog_leg....
dart/frog/leg/frog_leg.dart:21: 
On 2012/03/08 15:13:02, kasperl wrote:
> Maybe only one newline here?

Done.

https://chromiumcodereview.appspot.com/9639012/diff/1/dart/frog/leg/frog_leg....
dart/frog/leg/frog_leg.dart:43: String code = api.compile(uri, libraryRoot,
provider, handler).value;
On 2012/03/08 15:13:02, kasperl wrote:
> Maybe add a comment here too?

Done.

Expand Messages | Collapse Messages