Issue 9639010: Implement compilation of conditional expressions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9639010: Implement compilation of conditional expressions. (Closed)

Created:
8 years, 9 months ago by Kevin Millikin (Google)

Modified:
8 years, 9 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Implement compilation of conditional expressions. R=srdjan@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=5227

Patch Set 1 #

Total comments: 2

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -2 lines)			Patch
	M	runtime/vm/flow_graph_builder.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
	M	runtime/vm/flow_graph_builder.cc	View		1 chunk	+41 lines, -1 line	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

srdjan

LGTM https://chromiumcodereview.appspot.com/9639010/diff/1/runtime/vm/flow_graph_builder.cc File runtime/vm/flow_graph_builder.cc (right): https://chromiumcodereview.appspot.com/9639010/diff/1/runtime/vm/flow_graph_builder.cc#newcode558 runtime/vm/flow_graph_builder.cc:558: ASSERT(for_test.can_be_true() && for_test.can_be_false()); Again, what is the point ...

8 years, 9 months ago (2012-03-08 17:43:53 UTC) #2

Kevin Millikin (Google)

8 years, 9 months ago (2012-03-09 09:53:00 UTC) #3

https://chromiumcodereview.appspot.com/9639010/diff/1/runtime/vm/flow_graph_b...
File runtime/vm/flow_graph_builder.cc (right):

https://chromiumcodereview.appspot.com/9639010/diff/1/runtime/vm/flow_graph_b...
runtime/vm/flow_graph_builder.cc:558: ASSERT(for_test.can_be_true() &&
for_test.can_be_false());
On 2012/03/08 17:43:53, srdjan wrote:
> Again, what is the point of can_be_true and can_be_false? They are always
true,
> there is no way to test code that uses it (not here, but in other VisitXXX)

To support online constant folding of conditional expressions.

Expand Messages | Collapse Messages