Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 9638008: Change test_runner.dart to always move on in the batch runner if the batch runner crashed. (Closed)

Created:
8 years, 9 months ago by Mads Ager (google)
Modified:
8 years, 9 months ago
Reviewers:
Bill Hesse, zundel
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Change test_runner.dart to always move on in the batch runner if the batch runner crashed. If the batch runner crashes we close the streams and restart a new process. The other alternative is to distinguish between a hard crash or the java process and a soft crash where we throw an exception. On a soft crash we can put a token in stderr, wait for stderr to drain and then restart the process. I don't think that adds much. If there is a soft crash the crash indication is all that really matters and we need to fix that in any case before moving on. R=whesse@google.com,zundel@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=5156

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -31 lines) Patch
M tools/testing/dart/test_runner.dart View 19 chunks +33 lines, -31 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
Mads Ager (google)
8 years, 9 months ago (2012-03-08 09:14:06 UTC) #1
Bill Hesse
lgtm
8 years, 9 months ago (2012-03-08 09:15:42 UTC) #2
zundel
https://chromiumcodereview.appspot.com/9638008/diff/1/tools/testing/dart/test_runner.dart File tools/testing/dart/test_runner.dart (right): https://chromiumcodereview.appspot.com/9638008/diff/1/tools/testing/dart/test_runner.dart#newcode691 tools/testing/dart/test_runner.dart:691: if (_stdoutDrained) _testCompleted(); What about here?
8 years, 9 months ago (2012-03-08 12:22:16 UTC) #3
zundel
8 years, 9 months ago (2012-03-08 12:28:29 UTC) #4
https://chromiumcodereview.appspot.com/9638008/diff/1/tools/testing/dart/test...
File tools/testing/dart/test_runner.dart (right):

https://chromiumcodereview.appspot.com/9638008/diff/1/tools/testing/dart/test...
tools/testing/dart/test_runner.dart:691: if (_stdoutDrained) _testCompleted();
On 2012/03/08 12:22:16, zundel wrote:
> What about here?

nm, I guess we just wait for the process to exit and then _reportResult() will
be called from _exitHandler

Powered by Google App Engine
This is Rietveld 408576698