Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(707)

Issue 9634002: Use GrowableObjectArray in the debugger instance/static field lists. (Closed)

Created:
8 years, 9 months ago by siva
Modified:
8 years, 9 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Use GrowableObjectArray in the debugger instance/static field lists. Committed: https://code.google.com/p/dart/source/detail?r=5148

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -23 lines) Patch
M vm/debugger.cc View 1 3 chunks +18 lines, -23 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
siva
8 years, 9 months ago (2012-03-08 00:56:17 UTC) #1
hausner
LGTM The function ActivationFrame::GetDescIndices() could maybe also use a growable array and return the variable ...
8 years, 9 months ago (2012-03-08 01:06:56 UTC) #2
siva
8 years, 9 months ago (2012-03-08 01:24:15 UTC) #3
Thanks.

Added the TODO.

Powered by Google App Engine
This is Rietveld 408576698