Issue 9633015: Map typeName getter to the global typeNameOf. This is a unspoken rule from the native interface :)

Issue 9633015: Map typeName getter to the global typeNameOf. This is a unspoken rule from the native interface :) (Closed)

Created:
8 years, 9 months ago by ngeoffray

Modified:
8 years, 9 months ago

Reviewers:
sra1, kasperl

CC:
reviews_dartlang.org, ahe, floitsch, karlklose, Lasse Reichstein Nielsen

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Map typeName getter to the global typeNameOf. This is a unspoken rule from the native interface :) Committed: https://code.google.com/p/dart/source/detail?r=5170

Patch Set 2 : #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -3 lines)			Patch
M	client/tests/client/client-leg.status	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
M	frog/leg/elements/elements.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	frog/leg/native_handler.dart	View	1	1 chunk	+19 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

kasperl

https://chromiumcodereview.appspot.com/9633015/diff/1/client/tests/client/client-leg.status File client/tests/client/client-leg.status (right): https://chromiumcodereview.appspot.com/9633015/diff/1/client/tests/client/client-leg.status#newcode29 client/tests/client/client-leg.status:29: # We don't support is checks with generics types. ...

8 years, 9 months ago (2012-03-08 13:22:00 UTC) #2

ngeoffray

Thanks Kasper. https://chromiumcodereview.appspot.com/9633015/diff/1/client/tests/client/client-leg.status File client/tests/client/client-leg.status (right): https://chromiumcodereview.appspot.com/9633015/diff/1/client/tests/client/client-leg.status#newcode29 client/tests/client/client-leg.status:29: # We don't support is checks with ...

8 years, 9 months ago (2012-03-08 13:34:07 UTC) #4

sra1

8 years, 9 months ago (2012-03-08 21:04:33 UTC) #5

LGTM.

It would be a good idea to split TypedArrays1Test into universally passing tests
(TypedArrays1Test) and partially passing tests (e.g TypedArrays2Test)

Expand Messages | Collapse Messages