Issue 9630001: Build both dart:html and dart:dom bindings by default

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9630001: Build both dart:html and dart:dom bindings by default (Closed)

Created:
8 years, 9 months ago by Jacob

Modified:
8 years, 9 months ago

Reviewers:
sra1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Build both dart:html and dart:dom bindings by default BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=5146

Patch Set 2 : #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -19 lines)			Patch
	M	client/dom/scripts/dartdomgenerator.py	View	1	2 chunks	+19 lines, -19 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sra1

lgtm https://chromiumcodereview.appspot.com/9630001/diff/1/client/dom/scripts/dartdomgenerator.py File client/dom/scripts/dartdomgenerator.py (right): https://chromiumcodereview.appspot.com/9630001/diff/1/client/dom/scripts/dartdomgenerator.py#newcode180 client/dom/scripts/dartdomgenerator.py:180: dom_systems.append(system) OK, but could be: html_system_names = ['htmldartium', ...

8 years, 9 months ago (2012-03-08 00:51:33 UTC) #2

Jacob

8 years, 9 months ago (2012-03-08 00:54:19 UTC) #3

On 2012/03/08 00:51:33, sra1 wrote:
> lgtm
> 
>
https://chromiumcodereview.appspot.com/9630001/diff/1/client/dom/scripts/dart...
> File client/dom/scripts/dartdomgenerator.py (right):
> 
>
https://chromiumcodereview.appspot.com/9630001/diff/1/client/dom/scripts/dart...
> client/dom/scripts/dartdomgenerator.py:180: dom_systems.append(system)
> OK, but could be:
> 
> html_system_names = ['htmldartium', 'htmlfrog']
> html_systems = [s for s in systems if s in html_system_names]
> dom_systems = [s for s in systems if s not in html_system_names]

Done. that is the cleaner pythonic way of doing it.

Expand Messages | Collapse Messages

Issue 9630001: Build both dart:html and dart:dom bindings by default (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages