Issue 9625027: Fix bit-or and bit-xor for two negative bigints.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9625027: Fix bit-or and bit-xor for two negative bigints. (Closed)

Created:
8 years, 9 months ago by floitsch

Modified:
8 years, 9 months ago

Reviewers:
cshapiro, hausner

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix bit-or and bit-xor for two negative bigints. Fixes issue 2049. Committed: https://code.google.com/p/dart/source/detail?r=5142 Closed by hand since the server was under maintenance during the actual commit.

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+34 lines, -15 lines)			Patch
M	runtime/vm/bigint_operations.cc	View	4 chunks	+7 lines, -4 lines	0 comments	Download
M	runtime/vm/bigint_operations_test.cc	View	3 chunks	+27 lines, -7 lines	0 comments	Download
M	tests/co19/co19-runtime.status	View	1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages