Issue 9624005: Fix hostname lookup on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9624005: Fix hostname lookup on Windows (Closed)

Created:
8 years, 9 months ago by Søren Gjesse

Modified:
8 years, 9 months ago

Reviewers:
Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix hostname lookup on Windows The previous implementation was broken and did not use the result retreived from gethostbyname. Changed the implementation to use getaddrinfo as gethostbyname has been deprecated in the Winsock2 library. Added a test to test that something can be read from www.google.com. R=ager@google.com BUG=none TEST=tests/standalone/src/io/HttpClientTest.dart Committed: https://code.google.com/p/dart/source/detail?r=5097

Patch Set 1 #

Patch Set 2 : Minor fixes #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -7 lines)			Patch
	M	runtime/bin/socket_win.cc	View	1	1 chunk	+16 lines, -7 lines	0 comments	Download
	A	tests/standalone/src/io/HttpClientTest.dart	View		1 chunk	+28 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages