Issue 9620002: Handle Bigint.toCString when remainder equals 0.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9620002: Handle Bigint.toCString when remainder equals 0. (Closed)

Created:
8 years, 9 months ago by floitsch

Modified:
8 years, 9 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org, siva

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Handle Bigint.toCString when remainder equals 0. Committed: https://code.google.com/p/dart/source/detail?r=5081

Patch Set 2 : Address comment. #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -2 lines)			Patch
	M	runtime/vm/bigint_operations.cc	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download
	M	runtime/vm/bigint_operations_test.cc	View		1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM with a small nit: https://chromiumcodereview.appspot.com/9620002/diff/1/runtime/vm/bigint_operations.cc File runtime/vm/bigint_operations.cc (right): https://chromiumcodereview.appspot.com/9620002/diff/1/runtime/vm/bigint_operations.cc#newcode394 runtime/vm/bigint_operations.cc:394: intptr_t part = 0; ...

8 years, 9 months ago (2012-03-07 12:47:01 UTC) #2

floitsch

8 years, 9 months ago (2012-03-07 12:51:26 UTC) #3

https://chromiumcodereview.appspot.com/9620002/diff/1/runtime/vm/bigint_opera...
File runtime/vm/bigint_operations.cc (right):

https://chromiumcodereview.appspot.com/9620002/diff/1/runtime/vm/bigint_opera...
runtime/vm/bigint_operations.cc:394: intptr_t part = 0;
On 2012/03/07 12:47:01, kasperl wrote:
> intptr_t part = (remainder.Length() == 1)
>    ? static_cast<intptr_t>(remainder.GetChunkAt(0))
>    : 0;

Done.

Expand Messages | Collapse Messages

Issue 9620002: Handle Bigint.toCString when remainder equals 0. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address comment. #

Messages