Triage client failures on legium, and add the client tests to our presubmit script.

Triage client failures on legium, and add the client tests to our presubmit script.
Committed: https://code.google.com/p/dart/source/detail?r=5080

[kasperl, 2012-03-07 12:27:00]

LGTM!

[ahe, 2012-03-07 12:29:28]

https://chromiumcodereview.appspot.com/9620001/diff/1/frog/presubmit.py
File frog/presubmit.py (right):

https://chromiumcodereview.appspot.com/9620001/diff/1/frog/presubmit.py#newco...
frog/presubmit.py:174: cmd = test_cmd + ['--component=legium', 'client']
How long does it take to run this?

[ngeoffray, 2012-03-07 12:40:16]

Thanks Peter and Kasper

https://chromiumcodereview.appspot.com/9620001/diff/1/frog/presubmit.py
File frog/presubmit.py (right):

https://chromiumcodereview.appspot.com/9620001/diff/1/frog/presubmit.py#newco...
frog/presubmit.py:174: cmd = test_cmd + ['--component=legium', 'client']
On 2012/03/07 12:29:28, ahe wrote:
> How long does it take to run this?

20 seconds on my machine

[ahe, 2012-03-07 12:49:59]

https://chromiumcodereview.appspot.com/9620001/diff/1/frog/presubmit.py
File frog/presubmit.py (right):

https://chromiumcodereview.appspot.com/9620001/diff/1/frog/presubmit.py#newco...
frog/presubmit.py:174: cmd = test_cmd + ['--component=legium', 'client']
On 2012/03/07 12:40:16, ngeoffray wrote:
> On 2012/03/07 12:29:28, ahe wrote:
> > How long does it take to run this?
> 
> 20 seconds on my machine

OK. That is good. This is because you're only running the client tests.

Two problems:

1. You did not change dart/frog/scripts/buildbot_annotated_steps.py, so this is
not being run on the build bot.

2. What happens if I run "test.py -cleg -mrelease". My guess: a whole bunch of
tests will fail. It would be better if you remove ", 'client'" above and add
skip sections to all other test suites. It should be possible to invoke "test.py
-cleg -mrelease" without further options. Other teams rely on this.

[ngeoffray, 2012-03-07 12:56:03]

On 2012/03/07 12:49:59, ahe wrote:
> https://chromiumcodereview.appspot.com/9620001/diff/1/frog/presubmit.py
> File frog/presubmit.py (right):
> 
>
https://chromiumcodereview.appspot.com/9620001/diff/1/frog/presubmit.py#newco...
> frog/presubmit.py:174: cmd = test_cmd + ['--component=legium', 'client']
> On 2012/03/07 12:40:16, ngeoffray wrote:
> > On 2012/03/07 12:29:28, ahe wrote:
> > > How long does it take to run this?
> > 
> > 20 seconds on my machine
> 
> OK. That is good. This is because you're only running the client tests.
> 
> Two problems:
> 
> 1. You did not change dart/frog/scripts/buildbot_annotated_steps.py, so this
is
> not being run on the build bot.

Yes. I should have added to the description of the CL, that I will follow-up
with Emily and John to hook these tests in the browser tests.

> 
> 2. What happens if I run "test.py -cleg -mrelease". My guess: a whole bunch of
> tests will fail. It would be better if you remove ", 'client'" above and add
> skip sections to all other test suites. It should be possible to invoke
"test.py
> -cleg -mrelease" without further options. Other teams rely on this.

I guess you mean legium and not leg here. I will put a skip on other test suites
for legium.