Cases in a switch introduce a new scope.

Cases in a switch introduce a new scope.
Committed: https://code.google.com/p/dart/source/detail?r=5154

[ahe, 2012-03-07 22:24:15]

https://chromiumcodereview.appspot.com/9619028/diff/1001/frog/leg/resolver.dart
File frog/leg/resolver.dart (right):

https://chromiumcodereview.appspot.com/9619028/diff/1001/frog/leg/resolver.da...
frog/leg/resolver.dart:1164: visitIn(node.statements, new BlockScope(context));
I can't find this in the specification.

[ngeoffray, 2012-03-07 22:31:11]

https://chromiumcodereview.appspot.com/9619028/diff/1001/frog/leg/resolver.dart
File frog/leg/resolver.dart (right):

https://chromiumcodereview.appspot.com/9619028/diff/1001/frog/leg/resolver.da...
frog/leg/resolver.dart:1164: visitIn(node.statements, new BlockScope(context));
On 2012/03/07 22:24:15, ahe wrote:
> I can't find this in the specification.

We have a test for it SwitchScopeTest. And the JSON implementation of dart
assumes there is a new scope. Ergo, spec forgot to mention it :)

[floitsch, 2012-03-07 23:10:45]

LGTM.
This was definitely always the intention.
If the spec doesn't mention it, then it is a bug there.

[ngeoffray, 2012-03-08 08:50:35]

On 2012/03/07 23:10:45, floitsch wrote:
> LGTM.
> This was definitely always the intention.
> If the spec doesn't mention it, then it is a bug there.

I'll go ahead and submit. The spec needs updating for the switch.

[ahe, 2012-04-13 13:50:19]

Forgot to mail this. I'm not sure this is recorded anywhere, so please make sure
to file a spec bug.

http://codereview.chromium.org/9619028/diff/1001/frog/leg/resolver.dart
File frog/leg/resolver.dart (right):

http://codereview.chromium.org/9619028/diff/1001/frog/leg/resolver.dart#newco...
frog/leg/resolver.dart:1164: visitIn(node.statements, new BlockScope(context));
On 2012/03/07 22:31:11, ngeoffray wrote:
> On 2012/03/07 22:24:15, ahe wrote:
> > I can't find this in the specification.
> 
> We have a test for it SwitchScopeTest. And the JSON implementation of dart
> assumes there is a new scope. Ergo, spec forgot to mention it :)

Then you need to file a specification bug.

[ngeoffray, 2012-04-16 13:49:34]

http://codereview.chromium.org/9619028/diff/1001/frog/leg/resolver.dart
File frog/leg/resolver.dart (right):

http://codereview.chromium.org/9619028/diff/1001/frog/leg/resolver.dart#newco...
frog/leg/resolver.dart:1164: visitIn(node.statements, new BlockScope(context));
On 2012/04/13 13:50:19, ahe wrote:
> On 2012/03/07 22:31:11, ngeoffray wrote:
> > On 2012/03/07 22:24:15, ahe wrote:
> > > I can't find this in the specification.
> > 
> > We have a test for it SwitchScopeTest. And the JSON implementation of dart
> > assumes there is a new scope. Ergo, spec forgot to mention it :)
> 
> Then you need to file a specification bug.

Yes: http://code.google.com/p/dart/issues/detail?id=2057

[ahe, 2012-04-16 14:51:58]

http://codereview.chromium.org/9619028/diff/1001/frog/leg/resolver.dart
File frog/leg/resolver.dart (right):

http://codereview.chromium.org/9619028/diff/1001/frog/leg/resolver.dart#newco...
frog/leg/resolver.dart:1164: visitIn(node.statements, new BlockScope(context));
On 2012/04/16 13:49:35, ngeoffray wrote:
> On 2012/04/13 13:50:19, ahe wrote:
> > On 2012/03/07 22:31:11, ngeoffray wrote:
> > > On 2012/03/07 22:24:15, ahe wrote:
> > > > I can't find this in the specification.
> > > 
> > > We have a test for it SwitchScopeTest. And the JSON implementation of dart
> > > assumes there is a new scope. Ergo, spec forgot to mention it :)
> > 
> > Then you need to file a specification bug.
> 
> Yes: http://code.google.com/p/dart/issues/detail?id=2057

Thank you. Starred it :-)