Issue 9616044: Adds new apis Dart_GetField/Dart_SetField.

Issue 9616044: Adds new apis Dart_GetField/Dart_SetField. (Closed)

Created:
8 years, 9 months ago by turnidge

Modified:
8 years, 9 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

Adds new apis Dart_GetField/Dart_SetField. These are intended to replace Dart_{Get,Set}{Static,Instance}Field. --- Mess with Library::PrivateName. Add field/function lookup to Library. Committed: https://code.google.com/p/dart/source/detail?r=5124

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+641 lines, -20 lines)			Patch
M	include/dart_api.h	View	1	3 chunks	+55 lines, -2 lines	0 comments	Download
M	lib/isolate.cc	View	1	2 chunks	+6 lines, -2 lines	0 comments	Download
M	vm/dart_api_impl.cc	View	1	5 chunks	+257 lines, -8 lines	0 comments	Download
M	vm/dart_api_impl_test.cc	View	1	1 chunk	+253 lines, -0 lines	0 comments	Download
M	vm/dart_entry.cc	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	vm/object.h	View	1	2 chunks	+3 lines, -1 line	0 comments	Download
M	vm/object.cc	View	1	3 chunks	+64 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTMwC-ip https://chromiumcodereview.appspot.com/9616044/diff/1/include/dart_api.h File include/dart_api.h (right): https://chromiumcodereview.appspot.com/9616044/diff/1/include/dart_api.h#newcode1626 include/dart_api.h:1626: * This function ignores field visibility (underscores in ...

8 years, 9 months ago (2012-03-07 20:02:58 UTC) #2

turnidge

8 years, 9 months ago (2012-03-07 21:17:12 UTC) #3

https://chromiumcodereview.appspot.com/9616044/diff/1/include/dart_api.h
File include/dart_api.h (right):

https://chromiumcodereview.appspot.com/9616044/diff/1/include/dart_api.h#newc...
include/dart_api.h:1626: * This function ignores field visibility (underscores
in names).
On 2012/03/07 20:02:58, Ivan Posva wrote:
> leading underscores

Done.

https://chromiumcodereview.appspot.com/9616044/diff/1/include/dart_api.h#newc...
include/dart_api.h:1656: DART_EXPORT Dart_Handle Dart_SetField(Dart_Handle
container,
On 2012/03/07 20:02:58, Ivan Posva wrote:
> Please document that this also ignores privacy.

Done.

https://chromiumcodereview.appspot.com/9616044/diff/1/vm/object.cc
File vm/object.cc (right):

https://chromiumcodereview.appspot.com/9616044/diff/1/vm/object.cc#newcode4928
vm/object.cc:4928: // TODO(turnidge): Should check for prefix of "_", "get:_",
or "set:_" here.
On 2012/03/07 20:02:58, Ivan Posva wrote:
> ASSERT(name.CharAt(0) == '_');

Done...

Expand Messages | Collapse Messages