Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 9616012: Update SplayTreeMap with a work-around for frog. (Closed)

Created:
8 years, 9 months ago by Anders Johnsen
Modified:
8 years, 9 months ago
Reviewers:
ahe, kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Update SplayTreeMap with a work-around for frog. Committed: https://code.google.com/p/dart/source/detail?r=5026

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M corelib/src/implementation/splay_tree.dart View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Anders Johnsen
8 years, 9 months ago (2012-03-06 14:03:17 UTC) #1
kasperl
LGTM. I don't know why you would actually want that parameter to be optional. To ...
8 years, 9 months ago (2012-03-06 14:05:21 UTC) #2
Anders Johnsen
I agree, this is better. Thank you!
8 years, 9 months ago (2012-03-06 14:06:31 UTC) #3
ahe
Don't forget to update the status files. The frog build bots are now red because ...
8 years, 9 months ago (2012-03-06 15:42:49 UTC) #4
Jennifer Messerly
On 2012/03/06 15:42:49, ahe wrote: > Don't forget to update the status files. The frog ...
8 years, 9 months ago (2012-03-06 15:58:06 UTC) #5
Anders Johnsen
Sorry guys, I'm still getting used to the status files. I'll try to be more ...
8 years, 9 months ago (2012-03-06 16:31:08 UTC) #6
ahe
8 years, 9 months ago (2012-03-06 16:46:33 UTC) #7
On 2012/03/06 16:31:08, ajohnsen wrote:
> Sorry guys, I'm still getting used to the status files. I'll try to be more
> aware in the future!

As far as I'm concerned, the system works fine. You made the build bot red, and
you got a nag email. So what if it isn't fully automated? ;-)

Cheers,
Peter

Powered by Google App Engine
This is Rietveld 408576698