Issue 9616005: Turn CopyTemp and SetTemp into instructions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9616005: Turn CopyTemp and SetTemp into instructions. (Closed)

Created:
8 years, 9 months ago by Kevin Millikin (Google)

Modified:
8 years, 9 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Turn CopyTemp and SetTemp into instructions. These were always used and assumed to be in a stylized form (CopyTemp in Bind and SetTemp in Do). Make this required by the IL. This change allows eliminating the relative indexing in favor of temporary names, without restructuring the compiler at all. R=srdjan@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=5072

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+161 lines, -93 lines)			Patch
M	runtime/vm/flow_graph_builder.cc	View	4 chunks	+24 lines, -16 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	2 chunks	+22 lines, -15 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	6 chunks	+76 lines, -47 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	3 chunks	+39 lines, -15 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Google)

The names come from the Forth words PICK and TUCK which do (approximately) this. I ...

8 years, 9 months ago (2012-03-06 11:02:04 UTC) #1

LGTM

Expand Messages | Collapse Messages