Issue 9616004: Add handling of the HTTP header "Host"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9616004: Add handling of the HTTP header "Host" (Closed)

Created:
8 years, 9 months ago by Søren Gjesse

Modified:
8 years, 9 months ago

Reviewers:
Anders Johnsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add handling of the HTTP header "Host" R=ajohnsen@google.com BUG=none TEST=tests/standalone/src/io/HttpTest.dart Committed: https://code.google.com/p/dart/source/detail?r=5015

Patch Set 2 : Addressed review comments #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+125 lines, -11 lines)			Patch
M	runtime/bin/http.dart	View		5 chunks	+35 lines, -5 lines	0 comments	Download
M	runtime/bin/http_impl.dart	View	1	8 chunks	+43 lines, -6 lines	0 comments	Download
M	tests/standalone/src/io/HttpTest.dart	View		4 chunks	+47 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

LGTM, thank you for adding this! https://chromiumcodereview.appspot.com/9616004/diff/1/runtime/bin/http_impl.dart File runtime/bin/http_impl.dart (right): https://chromiumcodereview.appspot.com/9616004/diff/1/runtime/bin/http_impl.dart#newcode717 runtime/bin/http_impl.dart:717: Date get host() ...

8 years, 9 months ago (2012-03-06 10:29:57 UTC) #2

Søren Gjesse

8 years, 9 months ago (2012-03-06 10:59:05 UTC) #3

https://chromiumcodereview.appspot.com/9616004/diff/1/runtime/bin/http_impl.dart
File runtime/bin/http_impl.dart (right):

https://chromiumcodereview.appspot.com/9616004/diff/1/runtime/bin/http_impl.d...
runtime/bin/http_impl.dart:717: Date get host() => _host;
On 2012/03/06 10:29:57, ajohnsen wrote:
> String

Oops, forgot to run tests with type check turned on.

Expand Messages | Collapse Messages

Issue 9616004: Add handling of the HTTP header "Host" (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressed review comments #

Messages