Generate dynamic type errors according to spec.

Generate dynamic type errors according to spec.
Fix a few bad tests.
Turn a couple negative tests in multi-tests.
Triage a few co19 failing tests.

Still to do:
Check bounds of generic types at runtime in checked mode.
Stop reporting bounds error in new operator as a compile time error.
Committed: https://code.google.com/p/dart/source/detail?r=5064

[regis, 2012-03-06 23:09:27]

It is not as bad as it looks. Some code was moved from error.cc to
exceptions.cc.

Thanks,
Regis

[srdjan, 2012-03-07 00:41:23]

LGTM with comments & questions.

Please test frog and leg.

https://chromiumcodereview.appspot.com/9615035/diff/1/runtime/lib/error.dart
File runtime/lib/error.dart (right):

https://chromiumcodereview.appspot.com/9615035/diff/1/runtime/lib/error.dart#...
runtime/lib/error.dart:38: str +=
Do not use the deprecated + String operator.

https://chromiumcodereview.appspot.com/9615035/diff/1/runtime/vm/class_finali...
File runtime/vm/class_finalizer.cc (right):

https://chromiumcodereview.appspot.com/9615035/diff/1/runtime/vm/class_finali...
runtime/vm/class_finalizer.cc:176: OS::Print("%s\n",
malformed_error.ToErrorCString());
Shouldn't this be going to PrintErr?

https://chromiumcodereview.appspot.com/9615035/diff/1/runtime/vm/code_generat...
File runtime/vm/code_generator.cc (right):

https://chromiumcodereview.appspot.com/9615035/diff/1/runtime/vm/code_generat...
runtime/vm/code_generator.cc:358: // Arg0: index of the token of the instanceof
test (source location).
You should be able to get the token from the PcDesc (via DartFrame), I think,
especially since you need it only when throwing exception.
Actually, you don't seem to be needing it here at all?

https://chromiumcodereview.appspot.com/9615035/diff/1/runtime/vm/code_generat...
runtime/vm/code_generator.cc:415: // Arg0: index of the token of the assignment
(source location).
ditto here and below.

[regis, 2012-03-07 02:22:38]

I tested dartc, frog, frogsh, and leg in release mode. I'll watch the build bots
anyway.

Thanks,
Regis

https://chromiumcodereview.appspot.com/9615035/diff/1/runtime/lib/error.dart
File runtime/lib/error.dart (right):

https://chromiumcodereview.appspot.com/9615035/diff/1/runtime/lib/error.dart#...
runtime/lib/error.dart:38: str +=
On 2012/03/07 00:41:23, srdjan wrote:
> Do not use the deprecated + String operator.

Done.

https://chromiumcodereview.appspot.com/9615035/diff/1/runtime/vm/class_finali...
File runtime/vm/class_finalizer.cc (right):

https://chromiumcodereview.appspot.com/9615035/diff/1/runtime/vm/class_finali...
runtime/vm/class_finalizer.cc:176: OS::Print("%s\n",
malformed_error.ToErrorCString());
On 2012/03/07 00:41:23, srdjan wrote:
> Shouldn't this be going to PrintErr?

Done.

https://chromiumcodereview.appspot.com/9615035/diff/1/runtime/vm/code_generat...
File runtime/vm/code_generator.cc (right):

https://chromiumcodereview.appspot.com/9615035/diff/1/runtime/vm/code_generat...
runtime/vm/code_generator.cc:358: // Arg0: index of the token of the instanceof
test (source location).
On 2012/03/07 00:41:23, srdjan wrote:
> You should be able to get the token from the PcDesc (via DartFrame), I think,
> especially since you need it only when throwing exception.
> Actually, you don't seem to be needing it here at all?

The location is passed to Exceptions::CreateAndThrowTypeError below.

I have added a TODO.

https://chromiumcodereview.appspot.com/9615035/diff/1/runtime/vm/code_generat...
runtime/vm/code_generator.cc:415: // Arg0: index of the token of the assignment
(source location).
On 2012/03/07 00:41:23, srdjan wrote:
> ditto here and below.

Added TODO.