Issue 9608024: Add Dart_Invoke, which will replace Dart_InvokeDynamic and Dart_InvokeStatic.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9608024: Add Dart_Invoke, which will replace Dart_InvokeDynamic and Dart_InvokeStatic. (Closed)

Created:
8 years, 9 months ago by turnidge

Modified:
8 years, 9 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

Add Dart_Invoke, which will replace Dart_InvokeDynamic and Dart_InvokeStatic. Fixed Dart_SetField to allow us to set a field to null. Committed: https://code.google.com/p/dart/source/detail?r=5433

Patch Set 4 : #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+336 lines, -10 lines)			Patch
M	include/dart_api.h	View	1 2 3	4 chunks	+38 lines, -8 lines	0 comments	Download
M	vm/dart_api_impl.cc	View	1 2 3	2 chunks	+118 lines, -2 lines	0 comments	Download
M	vm/dart_api_impl_test.cc	View	1 2 3	2 chunks	+180 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTM with comment. -Ivan http://codereview.chromium.org/9608024/diff/6001/include/dart_api.h File include/dart_api.h (right): http://codereview.chromium.org/9608024/diff/6001/include/dart_api.h#newcode1679 include/dart_api.h:1679: DART_EXPORT Dart_Handle Dart_Invoke(Dart_Handle receiver, How ...

8 years, 9 months ago (2012-03-13 18:45:39 UTC) #2

turnidge

8 years, 9 months ago (2012-03-13 19:48:31 UTC) #3

http://codereview.chromium.org/9608024/diff/6001/include/dart_api.h
File include/dart_api.h (right):

http://codereview.chromium.org/9608024/diff/6001/include/dart_api.h#newcode1679
include/dart_api.h:1679: DART_EXPORT Dart_Handle Dart_Invoke(Dart_Handle
receiver,
On 2012/03/13 18:45:39, Ivan Posva wrote:
> How about renaming receiver to target? receiver sounds too much like a dynamic
> invoke to me.

Done.

Expand Messages | Collapse Messages

Issue 9608024: Add Dart_Invoke, which will replace Dart_InvokeDynamic and Dart_InvokeStatic. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Messages