Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Issue 9608003: Properly resolve relative paths with spaces (Closed)

Created:
8 years, 9 months ago by danrubel
Modified:
8 years, 9 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Properly resolve relative paths with spaces Committed: https://code.google.com/p/dart/source/detail?r=5150

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Messages

Total messages: 5 (0 generated)
danrubel
These changes help to properly handle directives such as #source('my source file with spaces.dart');
8 years, 9 months ago (2012-03-07 14:43:54 UTC) #1
Brian Wilkerson
Not sure whether this was ready for review, but LGTM https://chromiumcodereview.appspot.com/9608003/diff/1004/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/AnalysisServer.java File editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/AnalysisServer.java (right): https://chromiumcodereview.appspot.com/9608003/diff/1004/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/AnalysisServer.java#newcode317 ...
8 years, 9 months ago (2012-03-07 15:04:19 UTC) #2
danrubel
8 years, 9 months ago (2012-03-07 19:50:20 UTC) #3
danrubel
http://codereview.chromium.org/9608003/diff/1004/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/AnalysisServer.java File editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/AnalysisServer.java (right): http://codereview.chromium.org/9608003/diff/1004/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/AnalysisServer.java#newcode317 editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/AnalysisServer.java:317: return new File(resolved.getPath()); On 2012/03/07 15:04:19, Brian Wilkerson wrote: ...
8 years, 9 months ago (2012-03-07 20:07:29 UTC) #4
scheglov
8 years, 9 months ago (2012-03-07 21:26:02 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698