Issue 9605033: Implement a garbage collection prologue and epilogue callback mechanism.

Issue 9605033: Implement a garbage collection prologue and epilogue callback mechanism. (Closed)

Created:
8 years, 9 months ago by cshapiro

Modified:
8 years, 9 months ago

Reviewers:
turnidge

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Implement a garbage collection prologue and epilogue callback mechanism. Committed: https://code.google.com/p/dart/source/detail?r=5112

Patch Set 3 : address review comments #

Total comments: 2

Patch Set 4 : fix grammar #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+516 lines, -1 line)			Patch
M	runtime/include/dart_api.h	View	1 2	1 chunk	+69 lines, -0 lines	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View	1 2	1 chunk	+66 lines, -0 lines	0 comments	Download
M	runtime/vm/dart_api_impl_test.cc	View	1 2	1 chunk	+249 lines, -0 lines	0 comments	Download
A	runtime/vm/gc_callbacks.h	View	1 2 3	1 chunk	+111 lines, -0 lines	0 comments	Download
M	runtime/vm/gc_marker.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/gc_marker.cc	View	1 2	2 chunks	+9 lines, -1 line	0 comments	Download
M	runtime/vm/isolate.h	View	1 2	3 chunks	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

turnidge

https://chromiumcodereview.appspot.com/9605033/diff/2001/runtime/include/dart_api.h File runtime/include/dart_api.h (right): https://chromiumcodereview.appspot.com/9605033/diff/2001/runtime/include/dart_api.h#newcode275 runtime/include/dart_api.h:275: // --- Garbage Collection Callbacks -- Could add general ...

8 years, 9 months ago (2012-03-07 00:25:16 UTC) #2

cshapiro

PTAL https://chromiumcodereview.appspot.com/9605033/diff/2001/runtime/include/dart_api.h File runtime/include/dart_api.h (right): https://chromiumcodereview.appspot.com/9605033/diff/2001/runtime/include/dart_api.h#newcode275 runtime/include/dart_api.h:275: // --- Garbage Collection Callbacks -- On 2012/03/07 ...

8 years, 9 months ago (2012-03-07 03:06:10 UTC) #3

turnidge

LGTM, with one minor comment. https://chromiumcodereview.appspot.com/9605033/diff/4003/runtime/vm/gc_callbacks.h File runtime/vm/gc_callbacks.h (right): https://chromiumcodereview.appspot.com/9605033/diff/4003/runtime/vm/gc_callbacks.h#newcode78 runtime/vm/gc_callbacks.h:78: // Returns true if ...

8 years, 9 months ago (2012-03-07 17:28:37 UTC) #4

cshapiro

8 years, 9 months ago (2012-03-07 19:37:08 UTC) #5

https://chromiumcodereview.appspot.com/9605033/diff/4003/runtime/vm/gc_callba...
File runtime/vm/gc_callbacks.h (right):

https://chromiumcodereview.appspot.com/9605033/diff/4003/runtime/vm/gc_callba...
runtime/vm/gc_callbacks.h:78: // Returns true if the specified callback has is
present in the
Thanks, done.

Expand Messages | Collapse Messages