Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 9605009: Don't stringify unmatched groups and throw IllegalArgumentException for bad date strings. (Closed)

Created:
8 years, 9 months ago by ahe
Modified:
8 years, 9 months ago
Reviewers:
floitsch, ngeoffray
CC:
reviews_dartlang.org, compiler-dev_dartlang.org
Visibility:
Public.

Description

Don't stringify unmatched groups. Committed: https://code.google.com/p/dart/source/detail?r=5023

Patch Set 1 #

Total comments: 15

Patch Set 2 : Mention co19 issue number. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -112 lines) Patch
M dart/frog/leg/lib/mockimpl.dart View 1 chunk +1 line, -1 line 0 comments Download
M dart/frog/leg/lib/regexp_helper.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M dart/tests/co19/co19-leg.status View 1 12 chunks +16 lines, -109 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ahe
A bunch of co19 tests are failing because of this, I have filed co19 issue ...
8 years, 9 months ago (2012-03-06 12:06:05 UTC) #1
ngeoffray
I'm not sure I understand your comments. Are you saying the co19 tests are wrong?
8 years, 9 months ago (2012-03-06 12:14:30 UTC) #2
ahe
On 2012/03/06 12:14:30, ngeoffray wrote: > I'm not sure I understand your comments. Are you ...
8 years, 9 months ago (2012-03-06 12:29:10 UTC) #3
ngeoffray
8 years, 9 months ago (2012-03-06 12:36:09 UTC) #4
OK, thanks for explaining Peter. LGTM!

Powered by Google App Engine
This is Rietveld 408576698