Issue 9602011: Add handling of HTTP header "Expires"

Issue 9602011: Add handling of HTTP header "Expires" (Closed)

Created:
8 years, 9 months ago by Søren Gjesse

Modified:
8 years, 9 months ago

Reviewers:
Anders Johnsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add handling of HTTP header "Expires" The value of the "Expires" header is now available as a property on the HttpResponse and the HttpClientResponse. Added formatting of dates as HTTP dates in RFC 1123 format and parsing of HTTP dates in all three formats mentioned in RFC 2616. R=ajohnsen@google.com BUG=none TEST=tests/standalone/src/io/HttpDateTest.dart Committed: https://code.google.com/p/dart/source/detail?r=5016

Patch Set 1 #

Patch Set 2 : Fixed accidental edit #

Total comments: 14

Patch Set 3 : Addressed review comments #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+362 lines, -4 lines)			Patch
M	runtime/bin/http.dart	View	1 2	2 chunks	+14 lines, -0 lines	0 comments	Download
M	runtime/bin/http_impl.dart	View	1 2	5 chunks	+26 lines, -3 lines	0 comments	Download
M	runtime/bin/http_utils.dart	View	1 2	1 chunk	+168 lines, -0 lines	0 comments	Download
A	tests/standalone/src/io/HttpDateTest.dart	View		1 chunk	+91 lines, -0 lines	0 comments	Download
M	tests/standalone/src/io/HttpTest.dart	View	1 2	4 chunks	+63 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

LGTM, thank you! https://chromiumcodereview.appspot.com/9602011/diff/3001/runtime/bin/http_impl.dart File runtime/bin/http_impl.dart (right): https://chromiumcodereview.appspot.com/9602011/diff/3001/runtime/bin/http_impl.dart#newcode285 runtime/bin/http_impl.dart:285: if (_outputStream != null) return new ...

8 years, 9 months ago (2012-03-06 10:41:01 UTC) #2

Søren Gjesse

8 years, 9 months ago (2012-03-06 12:01:16 UTC) #3

https://chromiumcodereview.appspot.com/9602011/diff/3001/runtime/bin/http_imp...
File runtime/bin/http_impl.dart (right):

https://chromiumcodereview.appspot.com/9602011/diff/3001/runtime/bin/http_imp...
runtime/bin/http_impl.dart:285: if (_outputStream != null) return new
HttpException("Header already sent");
On 2012/03/06 10:41:01, ajohnsen wrote:
> throw

Done.

https://chromiumcodereview.appspot.com/9602011/diff/3001/runtime/bin/http_uti...
File runtime/bin/http_utils.dart (right):

https://chromiumcodereview.appspot.com/9602011/diff/3001/runtime/bin/http_uti...
runtime/bin/http_utils.dart:6: 
On 2012/03/06 10:41:01, ajohnsen wrote:
> Whitespace

Done.

https://chromiumcodereview.appspot.com/9602011/diff/3001/runtime/bin/http_uti...
runtime/bin/http_utils.dart:145: for (int i = 0; i < wkdays.length; i++) {
On 2012/03/06 10:41:01, ajohnsen wrote:
> wkdays.indexOf(tmp)?

I forgot about that API, thanks.

https://chromiumcodereview.appspot.com/9602011/diff/3001/runtime/bin/http_uti...
runtime/bin/http_utils.dart:150: }
On 2012/03/06 10:41:01, ajohnsen wrote:
> Is it an error if we end here? Maybe move the exception at line 166 down one
> line.

Done.

https://chromiumcodereview.appspot.com/9602011/diff/3001/runtime/bin/http_uti...
runtime/bin/http_utils.dart:154: for (int i = 0; i < wkdays.length; i++) {
On 2012/03/06 10:41:01, ajohnsen wrote:
> wkdays.indexOf(tmp)?

Done.

https://chromiumcodereview.appspot.com/9602011/diff/3001/runtime/bin/http_uti...
runtime/bin/http_utils.dart:160: for (int i = 0; i < weekdays.length; i++) {
On 2012/03/06 10:41:01, ajohnsen wrote:
> weekdays.indexOf(tmp)?

Done.

https://chromiumcodereview.appspot.com/9602011/diff/3001/runtime/bin/http_uti...
runtime/bin/http_utils.dart:175: for (int i = 0; i < months.length; i++) {
On 2012/03/06 10:41:01, ajohnsen wrote:
> months.indexOf(tmp)?

Done.

Expand Messages | Collapse Messages