New analyzeLibraries method

New analyzeLibraries method
Committed: https://code.google.com/p/dart/source/detail?r=4970

[danrubel, 2012-03-05 04:01:22]

Analyze a library along with any directly and indirectly referenced libraries.
Accept previously resolved libraries and any unresolved ASTs and return newly
resolved libraries.

[ahe, 2012-03-05 08:54:20]

LGTM

https://chromiumcodereview.appspot.com/9601005/diff/1/compiler/java/com/googl...
File compiler/java/com/google/dart/compiler/DartCompiler.java (right):

https://chromiumcodereview.appspot.com/9601005/diff/1/compiler/java/com/googl...
compiler/java/com/google/dart/compiler/DartCompiler.java:867:
Collection<LibraryUnit> getLibrariesToProcess() {
This should be O(1), not O(n*n).

https://chromiumcodereview.appspot.com/9601005/diff/1/compiler/java/com/googl...
compiler/java/com/google/dart/compiler/DartCompiler.java:1116: public static
LibraryUnit analyzeLibrary(LibrarySource lib, Map<URI, DartUnit> parsedUnits,
I don't think you need this overload, and I'd strongly recommend that you don't
add more overloads as it tends to complicate the API unnecessarily.

[danrubel, 2012-03-05 13:09:18]

https://chromiumcodereview.appspot.com/9601005/diff/1/compiler/java/com/googl...
File compiler/java/com/google/dart/compiler/DartCompiler.java (right):

https://chromiumcodereview.appspot.com/9601005/diff/1/compiler/java/com/googl...
compiler/java/com/google/dart/compiler/DartCompiler.java:867:
Collection<LibraryUnit> getLibrariesToProcess() {
On 2012/03/05 08:54:21, ahe wrote:
> This should be O(1), not O(n*n).

Good point. Cached.

https://chromiumcodereview.appspot.com/9601005/diff/1/compiler/java/com/googl...
compiler/java/com/google/dart/compiler/DartCompiler.java:1116: public static
LibraryUnit analyzeLibrary(LibrarySource lib, Map<URI, DartUnit> parsedUnits,
On 2012/03/05 08:54:21, ahe wrote:
> I don't think you need this overload, and I'd strongly recommend that you
don't
> add more overloads as it tends to complicate the API unnecessarily.

Agreed. I want to get the new API in place and tested before converting existing
callers and removing this method.