Resolve constructors with type arguments.

Resolve constructors with type arguments.

Committed: https://code.google.com/p/dart/source/detail?r=5131

[ngeoffray, 2012-03-07 11:32:06]

LGTM

https://chromiumcodereview.appspot.com/9600059/diff/1/dart/frog/leg/resolver....
File dart/frog/leg/resolver.dart (right):

https://chromiumcodereview.appspot.com/9600059/diff/1/dart/frog/leg/resolver....
dart/frog/leg/resolver.dart:1417: compiler.resolver.toResolve.add(cls);
You don't need to add it to the list of classes to resolve if you already
resolved it.

https://chromiumcodereview.appspot.com/9600059/diff/1/dart/frog/leg/resolver....
dart/frog/leg/resolver.dart:1443: compiler.resolver.toResolve.add(cls);
ditto

[ahe, 2012-03-07 11:34:31]

Hi Nicolas,

Thank you for taking a look. Am I right?

Cheers,
Peter

https://chromiumcodereview.appspot.com/9600059/diff/1/dart/frog/leg/resolver....
File dart/frog/leg/resolver.dart (right):

https://chromiumcodereview.appspot.com/9600059/diff/1/dart/frog/leg/resolver....
dart/frog/leg/resolver.dart:1417: compiler.resolver.toResolve.add(cls);
On 2012/03/07 11:32:06, ngeoffray wrote:
> You don't need to add it to the list of classes to resolve if you already
> resolved it. 

I think I do for its supertypes.

[ngeoffray, 2012-03-07 11:37:41]

https://chromiumcodereview.appspot.com/9600059/diff/1/dart/frog/leg/resolver....
File dart/frog/leg/resolver.dart (right):

https://chromiumcodereview.appspot.com/9600059/diff/1/dart/frog/leg/resolver....
dart/frog/leg/resolver.dart:1417: compiler.resolver.toResolve.add(cls);
On 2012/03/07 11:34:32, ahe wrote:
> On 2012/03/07 11:32:06, ngeoffray wrote:
> > You don't need to add it to the list of classes to resolve if you already
> > resolved it. 
> 
> I think I do for its supertypes.

I see. Initially, toResolve was only for delaying resolution of type
annotations. Why isn't the element.resolve method making sure the supertypes are
computed?

[karlklose, 2012-03-07 12:45:35]

LGTM.

[ahe, 2012-03-07 21:04:09]

Hi Nicolas and Karl,

Thank you for your suggestions.

Cheers,
Peter

https://chromiumcodereview.appspot.com/9600059/diff/1/dart/frog/leg/resolver....
File dart/frog/leg/resolver.dart (right):

https://chromiumcodereview.appspot.com/9600059/diff/1/dart/frog/leg/resolver....
dart/frog/leg/resolver.dart:1417: compiler.resolver.toResolve.add(cls);
On 2012/03/07 11:37:41, ngeoffray wrote:
> On 2012/03/07 11:34:32, ahe wrote:
> > On 2012/03/07 11:32:06, ngeoffray wrote:
> > > You don't need to add it to the list of classes to resolve if you already
> > > resolved it. 
> > 
> > I think I do for its supertypes.
> 
> I see. Initially, toResolve was only for delaying resolution of type
> annotations. Why isn't the element.resolve method making sure the supertypes
are
> computed?

OK. This is somewhat complicated. I have implemented it, but I think it should
be its own CL.