Issue 9600054: Supress /RTC1 when compiling /O2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9600054: Supress /RTC1 when compiling /O2. (Closed)

Created:
8 years, 9 months ago by cshapiro

Modified:
8 years, 9 months ago

Reviewers:
Anton Muhin, antonm, siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Supress /RTC1 when compiling /O2. Visual Studio's run-time error checks feature is sometimes enabled in debug builds. However, this flag is not compatible with the optimizer and, in a recent change, I enabled /O2 to decrease the build bot run times on Win32 builds. This caused an unintented breakage in Dartium which seems to enable /RTC1 in its debug build configuration. Committed: https://code.google.com/p/dart/source/detail?r=5046

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	tools/gyp/configurations_msvs.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM!

Expand Messages | Collapse Messages