Clean up temporary directories in buildbot script.

Clean up temporary directories in buildbot script.
Committed: https://code.google.com/p/dart/source/detail?r=4985

[Emily Fortuna, 2012-03-05 20:42:28]

The testing script does not always properly delete the temporary firefox
profiles when run in batch mode (but not repro'd outside the buildbots). Also on
Windows I have a scheduled task that cleans out the temporary files (see comment
in buildbot_annotated_steps.py). This change consolidates these fixes to that
they are part of the regular build cleanup.

[Siggi Cherem (dart-lang), 2012-03-05 21:22:25]

https://chromiumcodereview.appspot.com/9600033/diff/1001/frog/scripts/buildbo...
File frog/scripts/buildbot_annotated_steps.py (right):

https://chromiumcodereview.appspot.com/9600033/diff/1001/frog/scripts/buildbo...
frog/scripts/buildbot_annotated_steps.py:175: behavior has not been able to be
reproduced outside of the buildbots.
has not been able to be reproduced
=>
has not been reproduced

https://chromiumcodereview.appspot.com/9600033/diff/1001/frog/scripts/buildbo...
frog/scripts/buildbot_annotated_steps.py:188: p = subprocess.Popen('rm -rf
/tmp/*', shell=True)
This might be overly agressive - there might be temporary files needed there?
(we use to create our own temps in /tmp/ in test.py). Is there a prefix for the
firefox files that we can use here?

https://chromiumcodereview.appspot.com/9600033/diff/1001/frog/scripts/buildbo...
frog/scripts/buildbot_annotated_steps.py:218: if arch == 'frogium':
arch == webdriver?

[Emily Fortuna, 2012-03-05 21:50:18]

https://chromiumcodereview.appspot.com/9600033/diff/1001/frog/scripts/buildbo...
File frog/scripts/buildbot_annotated_steps.py (right):

https://chromiumcodereview.appspot.com/9600033/diff/1001/frog/scripts/buildbo...
frog/scripts/buildbot_annotated_steps.py:175: behavior has not been able to be
reproduced outside of the buildbots.
On 2012/03/05 21:22:25, sigmund wrote:
> has not been able to be reproduced
> =>
> has not been reproduced

Done.

https://chromiumcodereview.appspot.com/9600033/diff/1001/frog/scripts/buildbo...
frog/scripts/buildbot_annotated_steps.py:188: p = subprocess.Popen('rm -rf
/tmp/*', shell=True)
The firefox profiles all seem to have a particular format (a bunch of letters,
and maybe numbers), but no defining prefix. This runs after test.py is complete
(at the very end), so test.py shouldn't be relying on any temporary files lying
around...? Also if a file is still being used, the OS won't let you delete it
(tested on all OSs).

On 2012/03/05 21:22:25, sigmund wrote:
> This might be overly agressive - there might be temporary files needed there?
> (we use to create our own temps in /tmp/ in test.py). Is there a prefix for
the
> firefox files that we can use here?

https://chromiumcodereview.appspot.com/9600033/diff/1001/frog/scripts/buildbo...
frog/scripts/buildbot_annotated_steps.py:218: if arch == 'frogium':
See line 51. Webdriver is not the *architecture*, it is just the type of test to
run. 

On 2012/03/05 21:22:25, sigmund wrote:
> arch == webdriver?

[Siggi Cherem (dart-lang), 2012-03-05 22:10:44]

lgtm

[Jennifer Messerly, 2012-03-06 10:06:05]

lgtm too