Issue 9600017: Force not-Unicode version of libdart_builtin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9600017: Force not-Unicode version of libdart_builtin. (Closed)

Created:
8 years, 9 months ago by antonm

Modified:
8 years, 9 months ago

Reviewers:
Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Force not-Unicode version of libdart_builtin. Current implementation of file/process/etc. assumes it anyway. Committed: https://code.google.com/p/dart/source/detail?r=4955

Patch Set 3 : Addressing Mads' comments #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -3 lines)			Patch
	M	runtime/bin/bin.gypi	View	1 2	1 chunk	+13 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

LGTM as a temporary measure. https://chromiumcodereview.appspot.com/9600017/diff/1001/runtime/bin/bin.gypi File runtime/bin/bin.gypi (right): https://chromiumcodereview.appspot.com/9600017/diff/1001/runtime/bin/bin.gypi#newcode223 runtime/bin/bin.gypi:223: # TODO(antonm): fix the ...

8 years, 9 months ago (2012-03-05 14:36:10 UTC) #2

antonm

8 years, 9 months ago (2012-03-05 14:54:09 UTC) #3

https://chromiumcodereview.appspot.com/9600017/diff/1001/runtime/bin/bin.gypi
File runtime/bin/bin.gypi (right):

https://chromiumcodereview.appspot.com/9600017/diff/1001/runtime/bin/bin.gypi...
runtime/bin/bin.gypi:223: # TODO(antonm): fix the implementation.
On 2012/03/05 14:36:10, Mads Ager wrote:
> Could you expand this comment to be explicit about what needs to be done to
fix
> the implementation: switching to the A versions of APIs and dealing with that
> switch correctly.

Done.

Expand Messages | Collapse Messages

Issue 9600017: Force not-Unicode version of libdart_builtin. (Closed)

Description

Patch Set 1 #

Patch Set 2 : A TODO #

Patch Set 3 : Addressing Mads' comments #

Messages