Issue 9599020: New test exposes some bugs in the static analysis (dartc) engine on assignment problems

Issue 9599020: New test exposes some bugs in the static analysis (dartc) engine on assignment problems (Closed)

Created:
8 years, 9 months ago by zundel

Modified:
8 years, 9 months ago

Reviewers:
regis, ahe, ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

New test exposes some bugs in the static analysis (dartc) engine on assignment problems https://code.google.com/p/dart/source/detail?r=4963 Original review: http://codereview.chromium.org/9581032/ Committed: https://code.google.com/p/dart/source/detail?r=5206

Patch Set 2 : updates to pass on VM #

Patch Set 3 : Respin of AssignStaticTypeTest with multiple annotations #

Total comments: 3

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -0 lines)			Patch
	M	tests/language/language.status	View	1 2	2 chunks	+7 lines, -0 lines	1 comment	Download
	A	tests/language/src/AssignStaticTypeTest.dart	View	1 2	1 chunk	+33 lines, -0 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

zundel

I had this test pass review as https://chromiumcodereview.appspot.com/9581032/ but subsequently fail for --checked vm tests. ...

8 years, 9 months ago (2012-03-08 20:38:02 UTC) #1

regis

LGTM https://chromiumcodereview.appspot.com/9599020/diff/3001/tests/language/language.status File tests/language/language.status (right): https://chromiumcodereview.appspot.com/9599020/diff/3001/tests/language/language.status#newcode87 tests/language/language.status:87: AssignStaticTypeTest/02: Fail Please file a bug against the ...

8 years, 9 months ago (2012-03-08 20:47:50 UTC) #2

ngeoffray

https://chromiumcodereview.appspot.com/9599020/diff/3001/tests/language/src/AssignStaticTypeTest.dart File tests/language/src/AssignStaticTypeTest.dart (right): https://chromiumcodereview.appspot.com/9599020/diff/3001/tests/language/src/AssignStaticTypeTest.dart#newcode7 tests/language/src/AssignStaticTypeTest.dart:7: // VMOptions=--no-enable-type-checks How is that supposed to work, when ...

8 years, 9 months ago (2012-03-09 08:29:57 UTC) #3

ahe

8 years, 9 months ago (2012-03-09 08:31:17 UTC) #4

https://chromiumcodereview.appspot.com/9599020/diff/3001/tests/language/src/A...
File tests/language/src/AssignStaticTypeTest.dart (right):

https://chromiumcodereview.appspot.com/9599020/diff/3001/tests/language/src/A...
tests/language/src/AssignStaticTypeTest.dart:7: //
VMOptions=--no-enable-type-checks
I don't think we should have VM-specific options in shared tests.

Expand Messages | Collapse Messages