Issue 9597025: Removes unused 'normalized' field in many AST nodes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9597025: Removes unused 'normalized' field in many AST nodes. (Closed)

Created:
8 years, 9 months ago by zundel

Modified:
8 years, 9 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Removes unused 'normalized' field in many AST nodes. Committed: https://code.google.com/p/dart/source/detail?r=4959

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -102 lines)			Patch
M	compiler/java/com/google/dart/compiler/ast/DartBinaryExpression.java	View	2 chunks	+0 lines, -11 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/ast/DartCase.java	View	2 chunks	+0 lines, -11 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/ast/DartExpression.java	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/ast/DartForInStatement.java	View	2 chunks	+0 lines, -11 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/ast/DartIdentifier.java	View	2 chunks	+0 lines, -11 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/ast/DartMethodDefinition.java	View	2 chunks	+0 lines, -11 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/ast/DartNode.java	View	2 chunks	+1 line, -5 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/ast/DartParameter.java	View	2 chunks	+0 lines, -11 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/ast/DartPropertyAccess.java	View	3 chunks	+0 lines, -12 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/ast/DartToSourceVisitor.java	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/ast/DartUnaryExpression.java	View	2 chunks	+0 lines, -11 lines	0 comments	Download

Total messages: 2 (0 generated)

zundel

With the removal of code generation, the tree is not modified, so there is no ...

8 years, 9 months ago (2012-03-05 16:37:39 UTC) #1

LGTM