Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 9597015: Update Timer API to take the callback as the last parameter. (Closed)

Created:
8 years, 9 months ago by Mads Ager (google)
Modified:
8 years, 9 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Update Timer API to take the callback as the last parameter. This makes the code easier to read when the callback actually does work: new Timer(1000, (t) { // do // lots // of // stuff }); Also, it is more consistent with the rest of the APIs. R=sgjesse@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=4945

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -146 lines) Patch
M client/testing/unittest/unittest_vm.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/bin/chunked_stream.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/file_impl.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/bin/http_impl.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/list_stream_impl.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/bin/process_impl.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/stream_util.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/bin/string_stream.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/bin/timer.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/bin/timer_impl.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M samples/actors/core/actors-term.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/chat/chat_server.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/chat/chat_server_lib.dart View 2 chunks +2 lines, -2 lines 0 comments Download
D samples/socket/SocketExample.dart View 1 chunk +0 lines, -87 lines 0 comments Download
M tests/standalone/src/io/MultipleTimerTest.dart View 2 chunks +5 lines, -5 lines 0 comments Download
M tests/standalone/src/io/SocketCloseTest.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M tests/standalone/src/io/SocketStreamCloseTest.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M tests/standalone/src/io/TimerCancel1Test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/standalone/src/io/TimerCancel2Test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/standalone/src/io/TimerCancelTest.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M tests/standalone/src/io/TimerRepeatTest.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/standalone/src/io/TimerTest.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/testing/dart/test_runner.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M utils/tests/string_encoding/benchmark_runner.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (google)
8 years, 9 months ago (2012-03-05 11:29:36 UTC) #1
Søren Gjesse
8 years, 9 months ago (2012-03-05 11:32:13 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698