Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 9595024: Remove a build and 3-4 compiler warnings from com.google.dart.compiler.js. (Closed)

Created:
8 years, 9 months ago by devoncarew
Modified:
8 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove a build and 3-4 compiler warnings from com.google.dart.compiler.js. Committed: https://code.google.com/p/dart/source/detail?r=4964

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -7 lines) Patch
M compiler/java/com/google/dart/compiler/resolver/ClassElement.java View 1 chunk +0 lines, -1 line 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/ClassElementImplementation.java View 2 chunks +1 line, -1 line 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/DynamicElementImplementation.java View 1 chunk +0 lines, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.compiler.js/META-INF/MANIFEST.MF View 1 chunk +1 line, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.compiler.js/build.properties View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
devoncarew
@Brian, let me know if you think anyone else needs to be added as a ...
8 years, 9 months ago (2012-03-05 17:40:24 UTC) #1
Brian Wilkerson
8 years, 9 months ago (2012-03-05 17:45:29 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698