Issue 9595022: Removes a redundant mode_arch component from paths for generated tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9595022: Removes a redundant mode_arch component from paths for generated tests (Closed)

Created:
8 years, 9 months ago by zundel

Modified:
8 years, 9 months ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Removes a redundant mode_arch component from paths for generated tests Committed: https://code.google.com/p/dart/source/detail?r=4979

Patch Set 1 #

Total comments: 1

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -9 lines)			Patch
	M	tools/testing/dart/test_suite.dart	View		3 chunks	+10 lines, -9 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

zundel

Updates the path processing in createOutputDirectory() Also removes the --out flag on invoking dartc (no ...

8 years, 9 months ago (2012-03-05 16:05:47 UTC) #1

Bill Hesse

8 years, 9 months ago (2012-03-05 16:58:00 UTC) #2

LGTM.

https://chromiumcodereview.appspot.com/9595022/diff/1/tools/testing/dart/test...
File tools/testing/dart/test_suite.dart (right):

https://chromiumcodereview.appspot.com/9595022/diff/1/tools/testing/dart/test...
tools/testing/dart/test_suite.dart:647: debugMode + configuration["arch"];
I think you mean debugMode += configuration["arch"].
Wouldn't 
generatedTestPath = [debugMode +
configuration["arch"]].addAll(generatedTestPath);
be better?

or ( ... == 'debug') ? 
    'Debug_${configuration["arch"] :
    'Release_${configuration["arch"];

Remember they are taking away string concatenation (I think).


Actually - there is no need for this to match the build directory name anymore. 
Just use "${configuration['mode']_configuration['arch']".  You could even add it
to the end of the generatedTestPath, not the beginning.  You just need to make
the path different for different modes and arch.

Expand Messages | Collapse Messages