Issue 9592031: Eliminate IncrOpStaticFieldNode, replace a set of nodes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9592031: Eliminate IncrOpStaticFieldNode, replace a set of nodes. (Closed)

Created:
8 years, 9 months ago by srdjan

Modified:
8 years, 9 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Eliminate IncrOpStaticFieldNode, replace a set of nodes. Committed: https://code.google.com/p/dart/source/detail?r=5063

Patch Set 2 : #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -191 lines)			Patch
M	runtime/vm/ast.h	View		2 chunks	+0 lines, -58 lines	0 comments	Download
M	runtime/vm/ast.cc	View		3 chunks	+4 lines, -19 lines	0 comments	Download
M	runtime/vm/ast_printer.cc	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	runtime/vm/code_generator_ia32.cc	View		1 chunk	+0 lines, -45 lines	0 comments	Download
M	runtime/vm/code_generator_x64.cc	View		1 chunk	+0 lines, -45 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	runtime/vm/parser.cc	View	1	4 chunks	+48 lines, -13 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

hausner

LGTM modulo question below. https://chromiumcodereview.appspot.com/9592031/diff/1/runtime/vm/parser.cc File runtime/vm/parser.cc (right): https://chromiumcodereview.appspot.com/9592031/diff/1/runtime/vm/parser.cc#newcode5860 runtime/vm/parser.cc:5860: LocalVariable* temp = I'm not ...

8 years, 9 months ago (2012-03-06 23:44:13 UTC) #2

srdjan

8 years, 9 months ago (2012-03-07 00:19:28 UTC) #3

https://chromiumcodereview.appspot.com/9592031/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://chromiumcodereview.appspot.com/9592031/diff/1/runtime/vm/parser.cc#ne...
runtime/vm/parser.cc:5860: LocalVariable* temp =
On 2012/03/06 23:44:13, hausner wrote:
> I'm not sure why we need a temp variable at all. Is it not sufficient to build
> an ast branch like this (assuming ++ of the static field x in class C):
> 
> StaticSetterNode(C.x, BinaryOpNode(+, StaticGetterNode(C.x), 1)

That is correct. Changed.

Expand Messages | Collapse Messages

Issue 9592031: Eliminate IncrOpStaticFieldNode, replace a set of nodes. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages