Issue 9592009: Reapply "Refactor constant part." (r4958) with fixes.

Issue 9592009: Reapply "Refactor constant part." (r4958) with fixes. (Closed)

Created:
8 years, 9 months ago by floitsch

Modified:
8 years, 9 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Reapply "Refactor constant part." (r4958) with fixes. This reverts commit r4965. Committed: https://code.google.com/p/dart/source/detail?r=5027

Patch Set 2 : Update tests and fix code after renaming. #

Total comments: 2

Patch Set 3 : Add TODO. #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+294 lines, -427 lines)			Patch
M	frog/leg/compile_time_constants.dart	View		17 chunks	+37 lines, -41 lines	0 comments	Download
M	frog/leg/compiler.dart	View		5 chunks	+5 lines, -5 lines	0 comments	Download
M	frog/leg/emitter.dart	View		6 chunks	+8 lines, -8 lines	0 comments	Download
M	frog/leg/native_handler.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	frog/leg/ssa/builder.dart	View	1	15 chunks	+31 lines, -37 lines	0 comments	Download
M	frog/leg/ssa/codegen.dart	View		2 chunks	+13 lines, -29 lines	0 comments	Download
M	frog/leg/ssa/nodes.dart	View	1	37 chunks	+125 lines, -244 lines	0 comments	Download
M	frog/leg/ssa/optimize.dart	View	1 2	4 chunks	+36 lines, -33 lines	0 comments	Download
M	frog/leg/ssa/tracer.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	frog/leg/tree/nodes.dart	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	frog/tests/leg/src/BuiltinInterceptorTest.dart	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	frog/tests/leg/src/ClosureCodegenTest.dart	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	frog/tests/leg/src/ConstantFoldingTest.dart	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	frog/tests/leg/src/GVNTest.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	frog/tests/leg/src/LiteralListTest.dart	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	frog/tests/leg/src/PrettyParameterTest.dart	View	1	2 chunks	+4 lines, -5 lines	0 comments	Download
M	frog/tests/leg/src/SsaPhiEliminatorTest.dart	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	frog/tests/leg/src/TypeGuardUnuserTest.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	frog/tests/leg/src/TypeInferenceTest.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/co19/co19-leg.status	View		3 chunks	+0 lines, -3 lines	0 comments	Download
M	tests/language/language-leg.status	View		1 chunk	+0 lines, -1 line	0 comments	Download
A	tests/language/src/CompileTimeConstant9Test.dart	View		1 chunk	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

floitsch

Patchset 1 is the original CL. Patchset 2 contains the new changes.

8 years, 9 months ago (2012-03-06 13:47:35 UTC) #1

kasperl

LGTM. https://chromiumcodereview.appspot.com/9592009/diff/2001/frog/leg/ssa/optimize.dart File frog/leg/ssa/optimize.dart (right): https://chromiumcodereview.appspot.com/9592009/diff/2001/frog/leg/ssa/optimize.dart#newcode169 frog/leg/ssa/optimize.dart:169: compiler.builder.interceptors.getEqualsNullInterceptor()); It seems pretty common that you want ...

8 years, 9 months ago (2012-03-06 13:50:13 UTC) #2

floitsch

8 years, 9 months ago (2012-03-06 14:01:52 UTC) #3

https://chromiumcodereview.appspot.com/9592009/diff/2001/frog/leg/ssa/optimiz...
File frog/leg/ssa/optimize.dart (right):

https://chromiumcodereview.appspot.com/9592009/diff/2001/frog/leg/ssa/optimiz...
frog/leg/ssa/optimize.dart:169:
compiler.builder.interceptors.getEqualsNullInterceptor());
On 2012/03/06 13:50:13, kasperl wrote:
> It seems pretty common that you want to get hold of the interceptors. Maybe
> cache it somewhere in another CL?

I will look into it. Added TODO.

Expand Messages | Collapse Messages