Issue 9585005: Properly escape paths.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9585005: Properly escape paths. (Closed)

Created:
8 years, 9 months ago by antonm

Modified:
8 years, 9 months ago

Reviewers:
podivilov

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Properly escape paths. Otherwise on Windows we emitted a\b and \ just escaped the following character. Committed: https://code.google.com/p/dart/source/detail?r=4866

Patch Set 2 : Addressing Pavel's comment #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -3 lines)			Patch
	M	client/dom/scripts/systembase.py	View	1	2 chunks	+5 lines, -1 line	0 comments	Download
	M	client/dom/scripts/systemnative.py	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

podivilov

lgtm http://codereview.chromium.org/9585005/diff/1/client/dom/scripts/systembase.py File client/dom/scripts/systembase.py (right): http://codereview.chromium.org/9585005/diff/1/client/dom/scripts/systembase.py#newcode13 client/dom/scripts/systembase.py:13: def EscapePath(path): Please rename to FixDartPathSeparators or something ...

8 years, 9 months ago (2012-03-02 10:36:18 UTC) #2

antonm

8 years, 9 months ago (2012-03-02 10:41:53 UTC) #3

http://codereview.chromium.org/9585005/diff/1/client/dom/scripts/systembase.py
File client/dom/scripts/systembase.py (right):

http://codereview.chromium.org/9585005/diff/1/client/dom/scripts/systembase.p...
client/dom/scripts/systembase.py:13: def EscapePath(path):
On 2012/03/02 10:36:18, podivilov wrote:
> Please rename to FixDartPathSeparators or something alike.

Done.

Expand Messages | Collapse Messages

Issue 9585005: Properly escape paths. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressing Pavel's comment #

Messages