Update native keyword checking to accommodate frog

Update native keyword checking to accommodate frog
Committed: https://code.google.com/p/dart/source/detail?r=4969

[danrubel, 2012-03-02 08:21:41]

This accommodates usage of the native keyword in dom_frog.dart in the dart-sdk

[zundel, 2012-03-02 08:25:55]

https://chromiumcodereview.appspot.com/9585003/diff/1/compiler/java/com/googl...
File compiler/java/com/google/dart/compiler/parser/DartParser.java (right):

https://chromiumcodereview.appspot.com/9585003/diff/1/compiler/java/com/googl...
compiler/java/com/google/dart/compiler/parser/DartParser.java:621:
//reportError(position(), ParserErrorCode.NATIVE_MUST_NOT_EXTEND);
I'm wondering, if we move the corelibParse test first, and add dom_frog.dart to
trigger it, would that solve the issue without disabling the other error
checking?  Because it is still the case that native keyword is disallowed
outside of these libraries, right?

[zundel, 2012-03-02 08:58:45]

https://chromiumcodereview.appspot.com/9585003/diff/1/compiler/java/com/googl...
File compiler/java/com/google/dart/compiler/parser/DartParser.java (right):

https://chromiumcodereview.appspot.com/9585003/diff/1/compiler/java/com/googl...
compiler/java/com/google/dart/compiler/parser/DartParser.java:621:
//reportError(position(), ParserErrorCode.NATIVE_MUST_NOT_EXTEND);
On 2012/03/02 08:25:55, zundel wrote:
> I'm wondering, if we move the corelibParse test first, and add dom_frog.dart
to
> trigger it, would that solve the issue without disabling the other error
> checking?  Because it is still the case that native keyword is disallowed
> outside of these libraries, right?
no, that wouldn't work.

https://chromiumcodereview.appspot.com/9585003/diff/1/compiler/java/com/googl...
compiler/java/com/google/dart/compiler/parser/DartParser.java:628:
//reportError(position(), ParserErrorCode.NATIVE_ONLY_CORE_LIB);
I'd rather leave this test in, but if  corelibParse is set when parsing
dom_frog.dart, couldn't this pass?  I'd rather have an ugly hack to let
dom_frog.dart in than allow anyone to use native which is something we want to
be careful about.

[danrubel, 2012-03-03 05:55:15]

Comment addressed. PTAL.

https://chromiumcodereview.appspot.com/9585003/diff/1/compiler/java/com/googl...
File compiler/java/com/google/dart/compiler/parser/DartParser.java (right):

https://chromiumcodereview.appspot.com/9585003/diff/1/compiler/java/com/googl...
compiler/java/com/google/dart/compiler/parser/DartParser.java:628:
//reportError(position(), ParserErrorCode.NATIVE_ONLY_CORE_LIB);
On 2012/03/02 08:58:45, zundel wrote:
> I'd rather leave this test in, but if  corelibParse is set when parsing
> dom_frog.dart, couldn't this pass?  I'd rather have an ugly hack to let
> dom_frog.dart in than allow anyone to use native which is something we want to
> be careful about.  

Good point. I reviewed again and this is only a problem when editing the
dom_frog libraries as a user library. This is not a problem when importing them
as dart:dom.
Reverted.

[zundel, 2012-03-05 18:29:58]

lgtm
On 2012/03/03 05:55:15, danrubel wrote:
> Comment addressed. PTAL.
> 
>
https://chromiumcodereview.appspot.com/9585003/diff/1/compiler/java/com/googl...
> File compiler/java/com/google/dart/compiler/parser/DartParser.java (right):
> 
>
https://chromiumcodereview.appspot.com/9585003/diff/1/compiler/java/com/googl...
> compiler/java/com/google/dart/compiler/parser/DartParser.java:628:
> //reportError(position(), ParserErrorCode.NATIVE_ONLY_CORE_LIB);
> On 2012/03/02 08:58:45, zundel wrote:
> > I'd rather leave this test in, but if  corelibParse is set when parsing
> > dom_frog.dart, couldn't this pass?  I'd rather have an ugly hack to let
> > dom_frog.dart in than allow anyone to use native which is something we want
to
> > be careful about.  
> 
> Good point. I reviewed again and this is only a problem when editing the
> dom_frog libraries as a user library. This is not a problem when importing
them
> as dart:dom.
> Reverted.