Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 9584004: Revert "Enable use of #import stmts containing relative paths in Dart multitests" This change broke… (Closed)

Created:
8 years, 9 months ago by Jennifer Messerly
Modified:
8 years, 9 months ago
Reviewers:
antonm, zundel
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert "Enable use of #import stmts containing relative paths in Dart multitests" This change broke all of the browser tests, including DumpRenderTree. I'm not exactly sure what went wrong--perhaps something in the copying functions, because the breakage seems to affect all tests. Committed: https://code.google.com/p/dart/source/detail?r=4865

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -92 lines) Patch
M tools/testing/dart/multitest.dart View 5 chunks +11 lines, -57 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 2 chunks +9 lines, -35 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Jennifer Messerly
Hi Eric, Your CL here: https://chromiumcodereview.appspot.com//9565001 appears to have broken all the browser tests. You ...
8 years, 9 months ago (2012-03-02 10:20:12 UTC) #1
antonm
8 years, 9 months ago (2012-03-02 10:57:27 UTC) #2
Just FYI: it broke Dartium tests as well

Powered by Google App Engine
This is Rietveld 408576698