Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 9582040: Re-introduce string concatenation (Closed)

Created:
8 years, 9 months ago by hausner
Modified:
8 years, 9 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Re-introduce string concatenation This change re-introduces concatenation of adjacent string literals, i.e. the compiler concatenates "abc" "123" into the literal "abc123" at compile time. If the literals contain interpolations, the concatenation happens at runtime. The change also re-introduces interpolated compile-time string literal constants, but the feature is disabled because several tests need to be changed. Committed: https://code.google.com/p/dart/source/detail?r=4991

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -22 lines) Patch
M runtime/vm/parser.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/parser.cc View 1 2 3 chunks +69 lines, -22 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
hausner
A number of tests need to be fixed or deleted before we can turn on ...
8 years, 9 months ago (2012-03-03 02:01:16 UTC) #1
Ivan Posva
8 years, 9 months ago (2012-03-05 22:57:12 UTC) #2
LGTM -ip

Powered by Google App Engine
This is Rietveld 408576698