Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Issue 9582027: Some use of the new @static-clean and /// annotations in shared tests (Closed)

Created:
8 years, 9 months ago by zundel
Modified:
8 years, 9 months ago
Reviewers:
scheglov, Ivan Posva
CC:
reviews_dartlang.org, gbracha
Visibility:
Public.

Description

Some use of the new @static-clean and /// annotations in shared tests I'm hoping these will be non-controversial for starters. Committed: https://code.google.com/p/dart/source/detail?r=5237

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -85 lines) Patch
M tests/language/language.status View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/language/src/BadNamedParameters2Test.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M tests/language/src/BadNamedParametersTest.dart View 2 chunks +11 lines, -6 lines 0 comments Download
M tests/language/src/CallThroughGetterTest.dart View 1 chunk +6 lines, -2 lines 0 comments Download
M tests/language/src/Context2Test.dart View 2 chunks +4 lines, -1 line 0 comments Download
A tests/language/src/DefaultImplementation2Test.dart View 1 chunk +16 lines, -0 lines 0 comments Download
M tests/language/src/DefaultImplementationTest.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M tests/language/src/DynamicFieldTest.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language/src/DynamicTest.dart View 2 chunks +19 lines, -15 lines 0 comments Download
M tests/language/src/Factory2Test.dart View 2 chunks +19 lines, -9 lines 0 comments Download
D tests/language/src/ImplementTypeParameterNegativeTest.dart View 1 chunk +0 lines, -11 lines 0 comments Download
D tests/language/src/InstanceFieldNegativeTest.dart View 1 chunk +0 lines, -25 lines 0 comments Download
M tests/language/src/InterfaceTest.dart View 2 chunks +6 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
zundel
8 years, 9 months ago (2012-03-02 22:49:22 UTC) #1
scheglov
8 years, 9 months ago (2012-03-05 15:51:35 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698