Issue 9581032: New test exposes some bugs in the static analysis (dartc) engine on assignment problems

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9581032: New test exposes some bugs in the static analysis (dartc) engine on assignment problems (Closed)

Created:
8 years, 9 months ago by zundel

Modified:
8 years, 9 months ago

Reviewers:
gbracha

CC:
reviews_dartlang.org, rdayal_google.com, danrubel

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

New test exposes some bugs in the static analysis (dartc) engine on assignment problems http://code.google.com/p/dart/issues/detail?id=1957 Committed: https://code.google.com/p/dart/source/detail?r=4963

Patch Set 1 : new test for static analysis. #

Total comments: 2

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -0 lines)			Patch
	M	tests/language/language.status	View		1 chunk	+4 lines, -0 lines	0 comments	Download
	A	tests/language/src/AssignStaticTypeTest.dart	View		1 chunk	+33 lines, -0 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

gbracha

lgtm with comments http://codereview.chromium.org/9581032/diff/4/tests/language/src/AssignStaticTypeTest.dart File tests/language/src/AssignStaticTypeTest.dart (right): http://codereview.chromium.org/9581032/diff/4/tests/language/src/AssignStaticTypeTest.dart#newcode9 tests/language/src/AssignStaticTypeTest.dart:9: int a = "String"; /// 01: ...

8 years, 9 months ago (2012-03-05 16:51:08 UTC) #2

zundel

8 years, 9 months ago (2012-03-05 17:37:48 UTC) #3

http://codereview.chromium.org/9581032/diff/4/tests/language/src/AssignStatic...
File tests/language/src/AssignStaticTypeTest.dart (right):

http://codereview.chromium.org/9581032/diff/4/tests/language/src/AssignStatic...
tests/language/src/AssignStaticTypeTest.dart:9: int a = "String";  /// 01:
static type error
On 2012/03/05 16:51:08, gbracha wrote:
> Could we change all the comments 01 -06 in class A to say "static type
warning"
> instead of static type error? I'd like to firmly entrench the correct
> terminology to avoid confusion.

I agree it has caused lots of confusion. I will make a CL to do this (which will
touch a lot of files)

Expand Messages | Collapse Messages