Issue 9581025: Webdriver install script, take 2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9581025: Webdriver install script, take 2. (Closed)

Created:
8 years, 9 months ago by Emily Fortuna

Modified:
8 years, 9 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org, jmesserly_gmail.com

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Webdriver install script, take 2. Committed: https://code.google.com/p/dart/source/detail?r=4911

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+143 lines, -145 lines)			Patch
A +	tools/testing/browser_README.txt	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	tools/testing/dart/test_options.dart	View	1	1 chunk	+8 lines, -1 line	0 comments	Download
M	tools/testing/dart/test_runner.dart	View	1	12 chunks	+137 lines, -9 lines	0 comments	Download
D	tools/testing/perf_testing/buildbot_browser_test_setup.sh	View	1	1 chunk	+0 lines, -14 lines	0 comments	Download
D	tools/testing/perf_testing/perf_README.txt	View	1	1 chunk	+0 lines, -123 lines	0 comments	Download
A +	tools/testing/webdriver_test_setup.py	View		0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

The bug on the buildbot was that I had not accounted for the case where ...

8 years, 9 months ago (2012-03-02 22:45:35 UTC) #1

Siggi Cherem (dart-lang)

8 years, 9 months ago (2012-03-02 23:38:39 UTC) #2

lgtm, with the small fix we talked about...

https://chromiumcodereview.appspot.com/9581025/diff/2002/tools/testing/dart/t...
File tools/testing/dart/test_runner.dart (right):

https://chromiumcodereview.appspot.com/9581025/diff/2002/tools/testing/dart/t...
tools/testing/dart/test_runner.dart:778: var arg = [];
arg = ['axu']

Expand Messages | Collapse Messages