Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 9581011: Make the HttpParser and HttpUtil classes private (Closed)

Created:
8 years, 9 months ago by Søren Gjesse
Modified:
8 years, 9 months ago
Reviewers:
Mads Ager (google)
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make the HttpParser and HttpUtil classes private Move to separate files for sourcing these in the tests. R=ager@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=4934

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+493 lines, -486 lines) Patch
M runtime/bin/http_impl.dart View 5 chunks +5 lines, -478 lines 0 comments Download
A runtime/bin/http_parser.dart View 1 chunk +416 lines, -0 lines 0 comments Download
A runtime/bin/http_utils.dart View 1 chunk +62 lines, -0 lines 0 comments Download
M runtime/bin/io_sources.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/standalone/src/io/HttpParserTest.dart View 5 chunks +5 lines, -5 lines 0 comments Download
M tests/standalone/src/io/UrlEncodingTest.dart View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Gjesse
8 years, 9 months ago (2012-03-02 14:05:15 UTC) #1
Mads Ager (google)
8 years, 9 months ago (2012-03-05 06:52:22 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698