Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Issue 9581004: Update method used by analyzeLibrary to correctly identify dart:core (Closed)

Created:
8 years, 9 months ago by danrubel
Modified:
8 years, 9 months ago
Reviewers:
scheglov, zundel
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Update method used by analyzeLibrary to correctly identify dart:core Committed: https://code.google.com/p/dart/source/detail?r=4885

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M compiler/java/com/google/dart/compiler/DartCompiler.java View 2 chunks +4 lines, -1 line 2 comments Download

Messages

Total messages: 4 (0 generated)
danrubel
This fixes the editor's code completion tests
8 years, 9 months ago (2012-03-02 08:17:44 UTC) #1
zundel
https://chromiumcodereview.appspot.com/9581004/diff/1/compiler/java/com/google/dart/compiler/DartCompiler.java File compiler/java/com/google/dart/compiler/DartCompiler.java (right): https://chromiumcodereview.appspot.com/9581004/diff/1/compiler/java/com/google/dart/compiler/DartCompiler.java#newcode1146 compiler/java/com/google/dart/compiler/DartCompiler.java:1146: public static LibraryUnit findLibrary(LibraryUnit libraryUnit, String uri, nit, I ...
8 years, 9 months ago (2012-03-02 08:23:44 UTC) #2
danrubel
https://chromiumcodereview.appspot.com/9581004/diff/1/compiler/java/com/google/dart/compiler/DartCompiler.java File compiler/java/com/google/dart/compiler/DartCompiler.java (right): https://chromiumcodereview.appspot.com/9581004/diff/1/compiler/java/com/google/dart/compiler/DartCompiler.java#newcode1146 compiler/java/com/google/dart/compiler/DartCompiler.java:1146: public static LibraryUnit findLibrary(LibraryUnit libraryUnit, String uri, On 2012/03/02 ...
8 years, 9 months ago (2012-03-02 16:50:09 UTC) #3
zundel
8 years, 9 months ago (2012-03-02 16:57:21 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698