Revert "Refactor constant part."

Revert "Refactor constant part."

This reverts revision 4958.

Committed: https://code.google.com/p/dart/source/detail?r=4965

[ahe, 2012-03-05 17:55:25]

TBR.

Sorry, the build bot looked pretty broken, and I couldn't catch you on chat.

Cheers,
Peter

[ahe, 2012-03-05 17:56:49]

Example from build bot:

FAILED: leg release_ia32 frog_native/NativePropertyFrogTest
Expected: pass 
Actual: crash

stdout:
info: [leg] compiling
/mnt/data/b/build/slave/frogsh-linux-release/build/dart/frog/tests/native/src/NativePropertyFrogTest.dart
info: [leg] scanning library
file:///mnt/data/b/build/slave/frogsh-linux-release/build/dart/frog/leg/lib/coreimpl.dart
info: [leg] scanning library
file:///mnt/data/b/build/slave/frogsh-linux-release/build/dart/frog/leg/lib/js_helper.dart
info: [leg] scanning library
file:///mnt/data/b/build/slave/frogsh-linux-release/build/dart/frog/leg/lib/core.dart
info: [leg] scanning library
file:///mnt/data/b/build/slave/frogsh-linux-release/build/dart/frog/tests/native/src/NativePropertyFrogTest.dart
file:///mnt/data/b/build/slave/frogsh-linux-release/build/dart/frog/tests/native/src/NativePropertyFrogTest.dart:10:7:
warning: missing return.
  int getX() native 'return this._x;';
      ^
Internal error: NoSuchMethodException : method not found: 'addNewLiteralString'
Receiver: Instance of 'HGraph'
Arguments: [get$X]
 0. Function: 'Object.noSuchMethod' url: 'bootstrap' line:674 col:3
 1. Function: '::handleSsaNative' url:
'/mnt/data/b/build/slave/frogsh-linux-release/build/dart/frog/leg/native_handler.dart'
line:217 col:59
 2. Function: 'SsaBuilder.visitForeignSend' url:
'/mnt/data/b/build/slave/frogsh-linux-release/build/dart/frog/leg/ssa/builder.dart'
line:1765 col:31
 3. Function: 'SsaBuilder.visitSend' url:
'/mnt/data/b/build/slave/frogsh-linux-release/build/dart/frog/leg/ssa/builder.dart'
line:1831 col:25
 4. Function: 'Send.accept' url:
'/mnt/data/b/build/slave/frogsh-linux-release/build/dart/frog/leg/tree/nodes.dart'
line:225 col:47
 5. Function: 'SsaBuilder.visit' url:
'/mnt/data/b/build/slave/frogsh-linux-release/build/dart/frog/leg/ssa/builder.dart'
line:959 col:35
 6. Function: 'SsaBuilder.visitReturn' url:
'/mnt/data/b/build/slave/frogsh-linux-release/build/dart/frog/leg/ssa/builder.dart'
line:1972 col:12
 7. Function: 'Return.accept' url:
'/mnt/data/b/build/slave/frogsh-linux-release/build/dart/frog/leg/tree/nodes.dart'
line:986 col:49
 8. Function: 'SsaBuilder.visit' url:
'/mnt/data/b/build/slave/frogsh-linux-release/build/dart/frog/leg/ssa/builder.dart'
line:959 col:35
 9. Function: 'SsaBuilder.visitBlock' url:
'/mnt/data/b/build/slave/frogsh-linux-release/build/dart/frog/leg/ssa/builder.dart'
line:966 col:12
 10. Function: 'Block.accept' url:
'/mnt/data/b/build/slave/frogsh-linux-release/build/dart/frog/leg/tree/nodes.dart'
line:401 col:48
 11. Function: 'SsaBuilder.buildMethod' url:
'/mnt/data/b/build/slave/frogsh-linux-release/build/dart/frog/leg/ssa/builder.dart'
line:722 col:25
 12. Function: 'SsaBuilderTask.function' url:
'/mnt/data/b/build/slave/frogsh-linux-release/build/dart/frog/leg/ssa/builder.dart'
line:118 col:38
 13. Function: 'CompilerTask.measure' url:
'/mnt/data/b/build/slave/frogsh-linux-release/build/dart/frog/leg/compiler.dart'
line:400 col:24
 14. Function: 'SsaBuilderTask.build' url:
'/mnt/data/b/build/slave/frogsh-linux-release/build/dart/frog/leg/ssa/builder.dart'
line:105 col:19
 15. Function: 'Compiler.codegen' url:
'/mnt/data/b/build/slave/frogsh-linux-release/build/dart/frog/leg/compiler.dart'
line:302 col:35
 16. Function: 'Compiler.compile' url:
'/mnt/data/b/build/slave/frogsh-linux-release/build/dart/frog/leg/compiler.dart'
line:314 col:19
 17. Function: 'WorkItem.compile' url:
'/mnt/data/b/build/slave/frogsh-linux-release/build/dart/frog/leg/compiler.dart'
line:31 col:28
 18. Function: 'Compiler.function' url:
'/mnt/data/b/build/slave/frogsh-linux-release/build/dart/frog/leg/compiler.dart'
line:274 col:58
 19. Function: 'Compiler.withCurrentElement' url:
'/mnt/data/b/build/slave/frogsh-linux-release/build/dart/frog/leg/compiler.dart'
line:62 col:15
 20. Function: 'Compiler.withCurrentElement' url:
'/mnt/data/b/build/slave/frogsh-linux-release/build/dart/frog/leg/compiler.dart'
line:63 col:7
 21. Function: 'Compiler.runCompiler' url:
'/mnt/data/b/build/slave/frogsh-linux-release/build/dart/frog/leg/compiler.dart'
line:274 col:27
 22. Function: 'Compiler.run' url:
'/mnt/data/b/build/slave/frogsh-linux-release/build/dart/frog/leg/compiler.dart'
line:141 col:18
 23. Function: 'Compiler.run' url:
'/mnt/data/b/build/slave/frogsh-linux-release/build/dart/frog/leg/compiler.dart'
line:142 col:7
 24. Function: 'WorldCompiler.run' url:
'/mnt/data/b/build/slave/frogsh-linux-release/build/dart/frog/leg/frog_leg.dart'
line:41 col:29
 25. Function: '::compile' url:
'/mnt/data/b/build/slave/frogsh-linux-release/build/dart/frog/leg/frog_leg.dart'
line:21 col:22
 26. Function: 'World.function' url:
'/mnt/data/b/build/slave/frogsh-linux-release/build/dart/frog/world.dart'
line:402 col:60
 27. Function: 'World.withTiming' url:
'/mnt/data/b/build/slave/frogsh-linux-release/build/dart/frog/world.dart'
line:632 col:19
 28. Function: 'World.runLeg' url:
'/mnt/data/b/build/slave/frogsh-linux-release/build/dart/frog/world.dart'
line:402 col:26
 29. Function: 'World.compile' url:
'/mnt/data/b/build/slave/frogsh-linux-release/build/dart/frog/world.dart'
line:383 col:18
 30. Function: 'World.compile' url:
'/mnt/data/b/build/slave/frogsh-linux-release/build/dart/frog/world.dart'
line:389 col:9
 31. Function: 'World.compileAndSave' url:
'/mnt/data/b/build/slave/frogsh-linux-release/build/dart/frog/world.dart'
line:351 col:27
 32. Function: '::compile' url:
'/mnt/data/b/build/slave/frogsh-linux-release/build/dart/frog/world.dart'
line:40 col:30
 33. Function: '::main' url:
'/mnt/data/b/build/slave/frogsh-linux-release/build/dart/frog/minfrogc.dart'
line:32 col:15
 34. Function: '::main' url:
'/mnt/data/b/build/slave/frogsh-linux-release/build/dart/frog/frogc.dart'
line:12 col:18


Command line: out/Release_ia32/frog/bin/frog --ignore-unrecognized-flags
--verbose --leg
/mnt/data/b/build/slave/frogsh-linux-release/build/dart/frog/tests/native/src/NativePropertyFrogTest.dart

[ahe, 2012-03-05 17:57:00]

Another example from build bot:


FAILED: vm release_ia32 leg/SsaPhiEliminatorTest
Expected: pass 
Actual: fail

stderr:
Unhandled exception:
Expect.isTrue(false) fails.
 0. Function: 'Expect._fail@127eafe4' url: 'bootstrap' line:1457 col:5
 1. Function: 'Expect.isTrue' url: 'bootstrap' line:1201 col:10
 2. Function: '::main' url:
'/mnt/data/b/build/slave/frogsh-linux-release/build/dart/frog/tests/leg/src/SsaPhiEliminatorTest.dart'
line:60 col:16


Command line: out/Release_ia32/dart --ignore-unrecognized-flags
/mnt/data/b/build/slave/frogsh-linux-release/build/dart/frog/tests/leg/src/SsaPhiEliminatorTest.dart

[floitsch, 2012-03-06 10:31:01]

LGTM.
thanks. I did run the tests locally... Not sure what happened yet.