Issue 9572022: Support breakpoints in closures

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9572022: Support breakpoints in closures (Closed)

Created:
8 years, 9 months ago by hausner

Modified:
8 years, 9 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, podivilov1, Anton Muhin

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Support breakpoints in closures Properly set breakpoints in the code of closure functions. Fix bug 1894. Also renaming StackTrace to DebuggerStackTrace since we already have a class Stacktrace in the VM. Committed: https://code.google.com/p/dart/source/detail?r=4910

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+103 lines, -26 lines)			Patch
M	runtime/vm/debugger.h	View	1 2	4 chunks	+8 lines, -6 lines	0 comments	Download
M	runtime/vm/debugger.cc	View	1 2	10 chunks	+33 lines, -16 lines	0 comments	Download
M	runtime/vm/debugger_api_impl.cc	View	1 2	3 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/debugger_api_impl_test.cc	View	1	1 chunk	+59 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

hausner

Srdjan, would you be able to take a quick look? Thank you!

8 years, 9 months ago (2012-03-02 23:27:59 UTC) #2

LGTM

Expand Messages | Collapse Messages