Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9572005: Move all tests using dart:io to a separate directory (Closed)

Created:
8 years, 9 months ago by Søren Gjesse
Modified:
8 years, 9 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Move all tests using dart:io to a separate directory R=whesse@google.com, antonm@google.com, ager@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=4867

Patch Set 1 #

Total comments: 3

Patch Set 2 : Addressed review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-5 lines, -6462 lines) Patch
D tests/standalone/src/ChunkedStreamTest.dart View 1 chunk +0 lines, -140 lines 0 comments Download
D tests/standalone/src/DartStdIOPipeTest.dart View 1 chunk +0 lines, -101 lines 0 comments Download
D tests/standalone/src/DartStdIOPipeTest.sh View 1 chunk +0 lines, -13 lines 0 comments Download
D tests/standalone/src/DirectoryInvalidArgumentsTest.dart View 1 chunk +0 lines, -48 lines 0 comments Download
D tests/standalone/src/DirectoryTest.dart View 1 chunk +0 lines, -459 lines 0 comments Download
D tests/standalone/src/EchoServerStreamTest.dart View 1 chunk +0 lines, -176 lines 0 comments Download
D tests/standalone/src/EchoServerTest.dart View 1 chunk +0 lines, -198 lines 0 comments Download
D tests/standalone/src/FileInputStreamTest.dart View 1 chunk +0 lines, -104 lines 0 comments Download
D tests/standalone/src/FileInvalidArgumentsTest.dart View 1 chunk +0 lines, -201 lines 0 comments Download
D tests/standalone/src/FileOutputStreamTest.dart View 1 chunk +0 lines, -77 lines 0 comments Download
D tests/standalone/src/FileTest.dart View 1 chunk +0 lines, -1085 lines 0 comments Download
D tests/standalone/src/HttpParserTest.dart View 1 chunk +0 lines, -361 lines 0 comments Download
D tests/standalone/src/HttpTest.dart View 1 chunk +0 lines, -414 lines 0 comments Download
D tests/standalone/src/ListInputStreamTest.dart View 1 chunk +0 lines, -291 lines 0 comments Download
D tests/standalone/src/ListOutputStreamTest.dart View 1 chunk +0 lines, -93 lines 0 comments Download
D tests/standalone/src/ManyDirectoryOperationsTest.dart View 1 chunk +0 lines, -14 lines 0 comments Download
D tests/standalone/src/ManyEchoServerTest.dart View 1 chunk +0 lines, -19 lines 0 comments Download
D tests/standalone/src/ManyFileOperationsTest.dart View 1 chunk +0 lines, -14 lines 0 comments Download
D tests/standalone/src/MultipleTimerTest.dart View 1 chunk +0 lines, -75 lines 0 comments Download
D tests/standalone/src/OptionsTest.dart View 1 chunk +0 lines, -32 lines 0 comments Download
D tests/standalone/src/PlatformTest.dart View 1 chunk +0 lines, -14 lines 0 comments Download
D tests/standalone/src/ProcessBrokenPipeTest.dart View 1 chunk +0 lines, -21 lines 0 comments Download
D tests/standalone/src/ProcessExitNegativeTest.dart View 1 chunk +0 lines, -18 lines 0 comments Download
D tests/standalone/src/ProcessExitTest.dart View 1 chunk +0 lines, -25 lines 0 comments Download
D tests/standalone/src/ProcessInvalidArgumentsTest.dart View 1 chunk +0 lines, -16 lines 0 comments Download
D tests/standalone/src/ProcessSegfaultTest.dart View 1 chunk +0 lines, -24 lines 0 comments Download
D tests/standalone/src/ProcessStartExceptionTest.dart View 1 chunk +0 lines, -28 lines 0 comments Download
D tests/standalone/src/ProcessStdIOScript.dart View 1 chunk +0 lines, -24 lines 0 comments Download
D tests/standalone/src/ProcessStderrTest.dart View 1 chunk +0 lines, -72 lines 0 comments Download
D tests/standalone/src/ProcessStdoutTest.dart View 1 chunk +0 lines, -72 lines 0 comments Download
D tests/standalone/src/ProcessTestUtil.dart View 1 chunk +0 lines, -44 lines 0 comments Download
D tests/standalone/src/ProcessWorkingDirectoryTest.dart View 1 chunk +0 lines, -67 lines 0 comments Download
D tests/standalone/src/ReadIntoConstList.dart View 1 chunk +0 lines, -27 lines 0 comments Download
D tests/standalone/src/Regress-1925.dart View 1 chunk +0 lines, -70 lines 0 comments Download
D tests/standalone/src/SocketCloseTest.dart View 1 chunk +0 lines, -389 lines 0 comments Download
D tests/standalone/src/SocketExceptionTest.dart View 1 chunk +0 lines, -180 lines 0 comments Download
D tests/standalone/src/SocketManyConnectionsTest.dart View 1 chunk +0 lines, -92 lines 0 comments Download
D tests/standalone/src/SocketStreamCloseTest.dart View 1 chunk +0 lines, -416 lines 0 comments Download
D tests/standalone/src/StatusFileParserTest.dart View 1 chunk +0 lines, -42 lines 0 comments Download
D tests/standalone/src/StreamPipeTest.dart View 1 chunk +0 lines, -294 lines 0 comments Download
D tests/standalone/src/StringStreamTest.dart View 1 chunk +0 lines, -164 lines 0 comments Download
D tests/standalone/src/TestExtensionTest.dart View 1 chunk +0 lines, -16 lines 0 comments Download
D tests/standalone/src/TestRunnerTest.dart View 1 chunk +0 lines, -77 lines 0 comments Download
D tests/standalone/src/TestingServer.dart View 1 chunk +0 lines, -64 lines 0 comments Download
D tests/standalone/src/TimerCancel1Test.dart View 1 chunk +0 lines, -32 lines 0 comments Download
D tests/standalone/src/TimerCancel2Test.dart View 1 chunk +0 lines, -26 lines 0 comments Download
D tests/standalone/src/TimerCancelTest.dart View 1 chunk +0 lines, -42 lines 0 comments Download
D tests/standalone/src/TimerRepeatTest.dart View 1 chunk +0 lines, -41 lines 0 comments Download
D tests/standalone/src/TimerTest.dart View 1 chunk +0 lines, -43 lines 0 comments Download
D tests/standalone/src/UrlEncodingTest.dart View 1 chunk +0 lines, -29 lines 0 comments Download
A + tests/standalone/src/io/ChunkedStreamTest.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/standalone/src/io/DartStdIOPipeTest.dart View 1 chunk +4 lines, -4 lines 0 comments Download
A + tests/standalone/src/io/DartStdIOPipeTest.sh View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/standalone/src/io/DirectoryInvalidArgumentsTest.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/standalone/src/io/DirectoryTest.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/standalone/src/io/EchoServerStreamTest.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/standalone/src/io/EchoServerTest.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/standalone/src/io/FileInputStreamTest.dart View 4 chunks +4 lines, -4 lines 0 comments Download
A + tests/standalone/src/io/FileInvalidArgumentsTest.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/standalone/src/io/FileOutputStreamTest.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/standalone/src/io/FileTest.dart View 3 chunks +3 lines, -3 lines 0 comments Download
A + tests/standalone/src/io/HttpParserTest.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/standalone/src/io/HttpTest.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/standalone/src/io/ListInputStreamTest.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/standalone/src/io/ListOutputStreamTest.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/standalone/src/io/ManyDirectoryOperationsTest.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/standalone/src/io/ManyEchoServerTest.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/standalone/src/io/ManyFileOperationsTest.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/standalone/src/io/MultipleTimerTest.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/standalone/src/io/OptionsTest.dart View 2 chunks +3 lines, -3 lines 0 comments Download
A + tests/standalone/src/io/PlatformTest.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/standalone/src/io/ProcessBrokenPipeTest.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/standalone/src/io/ProcessExitNegativeTest.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/standalone/src/io/ProcessExitTest.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/standalone/src/io/ProcessInvalidArgumentsTest.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/standalone/src/io/ProcessSegfaultTest.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/standalone/src/io/ProcessStartExceptionTest.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/standalone/src/io/ProcessStdIOScript.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/standalone/src/io/ProcessStderrTest.dart View 2 chunks +2 lines, -3 lines 0 comments Download
A + tests/standalone/src/io/ProcessStdoutTest.dart View 2 chunks +2 lines, -3 lines 0 comments Download
A + tests/standalone/src/io/ProcessTestUtil.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/standalone/src/io/ProcessWorkingDirectoryTest.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/standalone/src/io/ReadIntoConstList.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/standalone/src/io/Regress-1925.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/standalone/src/io/SocketCloseTest.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/standalone/src/io/SocketExceptionTest.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/standalone/src/io/SocketManyConnectionsTest.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/standalone/src/io/SocketStreamCloseTest.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/standalone/src/io/StatusFileParserTest.dart View 1 chunk +1 line, -1 line 0 comments Download
A + tests/standalone/src/io/StreamPipeTest.dart View 4 chunks +4 lines, -4 lines 0 comments Download
A + tests/standalone/src/io/StringStreamTest.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/standalone/src/io/TestExtensionTest.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/standalone/src/io/TestRunnerTest.dart View 2 chunks +3 lines, -6 lines 0 comments Download
A + tests/standalone/src/io/TestingServer.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/standalone/src/io/TimerCancel1Test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/standalone/src/io/TimerCancel2Test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/standalone/src/io/TimerCancelTest.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/standalone/src/io/TimerRepeatTest.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/standalone/src/io/TimerTest.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/standalone/src/io/UrlEncodingTest.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/standalone/src/io/read_as_text.dat View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/standalone/src/io/readline_test1.dat View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/standalone/src/io/readline_test2.dat View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/standalone/src/io/readuntil_test.dat View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/standalone/src/io/test_extension.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
D tests/standalone/src/read_as_text.dat View 1 chunk +0 lines, -1 line 0 comments Download
D tests/standalone/src/readline_test1.dat View 1 chunk +0 lines, -10 lines 0 comments Download
D tests/standalone/src/readline_test2.dat View 1 chunk +0 lines, -10 lines 0 comments Download
D tests/standalone/src/readuntil_test.dat View 1 chunk +0 lines, -2 lines 0 comments Download
D tests/standalone/src/test_extension.dart View 1 chunk +0 lines, -18 lines 0 comments Download
M tests/standalone/standalone.status View 1 1 chunk +12 lines, -51 lines 0 comments Download
M tests/standalone/test_config.dart View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Søren Gjesse
8 years, 9 months ago (2012-03-02 09:29:45 UTC) #1
antonm
LGTM! And thanks a lot. https://chromiumcodereview.appspot.com/9572005/diff/1/tests/standalone/standalone.status File tests/standalone/standalone.status (right): https://chromiumcodereview.appspot.com/9572005/diff/1/tests/standalone/standalone.status#newcode30 tests/standalone/standalone.status:30: io/*: Skip # Don't ...
8 years, 9 months ago (2012-03-02 09:35:18 UTC) #2
Mads Ager (google)
lgtm https://chromiumcodereview.appspot.com/9572005/diff/1/tests/standalone/standalone.status File tests/standalone/standalone.status (right): https://chromiumcodereview.appspot.com/9572005/diff/1/tests/standalone/standalone.status#newcode8 tests/standalone/standalone.status:8: FailTest: Fail # Fails intentionally This should be ...
8 years, 9 months ago (2012-03-02 09:39:49 UTC) #3
Søren Gjesse
8 years, 9 months ago (2012-03-02 10:56:12 UTC) #4 
https://chromiumcodereview.appspot.com/9572005/diff/1/tests/standalone/standa...
File tests/standalone/standalone.status (right):

https://chromiumcodereview.appspot.com/9572005/diff/1/tests/standalone/standa...
tests/standalone/standalone.status:8: FailTest: Fail # Fails intentionally
On 2012/03/02 09:39:49, Mads Ager wrote:
> This should be Fail, OK
> 
> That way it is reflected in the --report outcome that it fails and we do not
> want to fix it. :)

Done.

Powered by Google App Engine
This is Rietveld 408576698